Linux IIO development
 help / color / mirror / Atom feed
From: Denis Ciocca <denis.ciocca@st.com>
To: Giuseppe BARBA <giuseppe.barba@st.com>
Cc: "linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
	"daniel.baluta@gmail.com" <daniel.baluta@gmail.com>,
	"jic23@kernel.org" <jic23@kernel.org>
Subject: Re: [PATCH v3] iio: st-accel: add support for lis2dh12
Date: Thu, 12 Nov 2015 14:38:01 +0800	[thread overview]
Message-ID: <2839481.F2NthOBxx5@hp-zbook-15-g2> (raw)
In-Reply-To: <1447255776-11101-1-git-send-email-giuseppe.barba@st.com>

Hi Giuseppe,

Can u please also include the Kconfig text integration with the new sensor? The 
driver is generic, people can easily read using Kconfig help supported sensors.

Denis


On Wednesday, November 11, 2015 04:29:36 PM Giuseppe BARBA wrote:
> This commit add support for STMicroelectronics lis2dh12 accelerometer.
> Datasheet for this device can be found here:
> 
> http://www.st.com/st-web-ui/static/active/en/resource/technical/
> document/datasheet/DM00091513.pdf
> 
> Signed-off-by: Giuseppe Barba <giuseppe.barba@st.com>
> ---
>  Documentation/devicetree/bindings/iio/st-sensors.txt | 1 +
>  drivers/iio/accel/st_accel.h                         | 1 +
>  drivers/iio/accel/st_accel_core.c                    | 1 +
>  drivers/iio/accel/st_accel_i2c.c                     | 5 +++++
>  drivers/iio/accel/st_accel_spi.c                     | 1 +
>  5 files changed, 9 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/iio/st-sensors.txt
> b/Documentation/devicetree/bindings/iio/st-sensors.txt index
> d3ccdb1..d4b87cc 100644
> --- a/Documentation/devicetree/bindings/iio/st-sensors.txt
> +++ b/Documentation/devicetree/bindings/iio/st-sensors.txt
> @@ -36,6 +36,7 @@ Accelerometers:
>  - st,lsm303dlm-accel
>  - st,lsm330-accel
>  - st,lsm303agr-accel
> +- st,lis2dh12-accel
> 
>  Gyroscopes:
>  - st,l3g4200d-gyro
> diff --git a/drivers/iio/accel/st_accel.h b/drivers/iio/accel/st_accel.h
> index 468f21f..5d4a189 100644
> --- a/drivers/iio/accel/st_accel.h
> +++ b/drivers/iio/accel/st_accel.h
> @@ -27,6 +27,7 @@
>  #define LSM303DLM_ACCEL_DEV_NAME	"lsm303dlm_accel"
>  #define LSM330_ACCEL_DEV_NAME		"lsm330_accel"
>  #define LSM303AGR_ACCEL_DEV_NAME	"lsm303agr_accel"
> +#define LIS2DH12_ACCEL_DEV_NAME		"lis2dh12_accel"
> 
>  /**
>  * struct st_sensors_platform_data - default accel platform data
> diff --git a/drivers/iio/accel/st_accel_core.c
> b/drivers/iio/accel/st_accel_core.c index dab8b76..9d973f1 100644
> --- a/drivers/iio/accel/st_accel_core.c
> +++ b/drivers/iio/accel/st_accel_core.c
> @@ -234,6 +234,7 @@ static const struct st_sensor_settings
> st_accel_sensors_settings[] = { [3] = LSM330DL_ACCEL_DEV_NAME,
>  			[4] = LSM330DLC_ACCEL_DEV_NAME,
>  			[5] = LSM303AGR_ACCEL_DEV_NAME,
> +			[6] = LIS2DH12_ACCEL_DEV_NAME,
>  		},
>  		.ch = (struct iio_chan_spec *)st_accel_12bit_channels,
>  		.odr = {
> diff --git a/drivers/iio/accel/st_accel_i2c.c
> b/drivers/iio/accel/st_accel_i2c.c index 8b9cc84..294a32f 100644
> --- a/drivers/iio/accel/st_accel_i2c.c
> +++ b/drivers/iio/accel/st_accel_i2c.c
> @@ -72,6 +72,10 @@ static const struct of_device_id st_accel_of_match[] = {
>  		.compatible = "st,lsm303agr-accel",
>  		.data = LSM303AGR_ACCEL_DEV_NAME,
>  	},
> +	{
> +		.compatible = "st,lis2dh12-accel",
> +		.data = LIS2DH12_ACCEL_DEV_NAME,
> +	},
>  	{},
>  };
>  MODULE_DEVICE_TABLE(of, st_accel_of_match);
> @@ -121,6 +125,7 @@ static const struct i2c_device_id st_accel_id_table[] =
> { { LSM303DLM_ACCEL_DEV_NAME },
>  	{ LSM330_ACCEL_DEV_NAME },
>  	{ LSM303AGR_ACCEL_DEV_NAME },
> +	{ LIS2DH12_ACCEL_DEV_NAME },
>  	{},
>  };
>  MODULE_DEVICE_TABLE(i2c, st_accel_id_table);
> diff --git a/drivers/iio/accel/st_accel_spi.c
> b/drivers/iio/accel/st_accel_spi.c index 54b61a3..e82bedf 100644
> --- a/drivers/iio/accel/st_accel_spi.c
> +++ b/drivers/iio/accel/st_accel_spi.c
> @@ -58,6 +58,7 @@ static const struct spi_device_id st_accel_id_table[] = {
>  	{ LSM303DLM_ACCEL_DEV_NAME },
>  	{ LSM330_ACCEL_DEV_NAME },
>  	{ LSM303AGR_ACCEL_DEV_NAME },
> +	{ LIS2DH12_ACCEL_DEV_NAME },
>  	{},
>  };
>  MODULE_DEVICE_TABLE(spi, st_accel_id_table);


  reply	other threads:[~2015-11-12  6:38 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-11 15:29 [PATCH v3] iio: st-accel: add support for lis2dh12 Giuseppe Barba
2015-11-12  6:38 ` Denis Ciocca [this message]
2015-11-12  7:35   ` Giuseppe BARBA

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2839481.F2NthOBxx5@hp-zbook-15-g2 \
    --to=denis.ciocca@st.com \
    --cc=daniel.baluta@gmail.com \
    --cc=giuseppe.barba@st.com \
    --cc=jic23@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox