From: Marek Vasut <marex@denx.de>
To: Jonathan Cameron <jic23@kernel.org>
Cc: linux-iio@vger.kernel.org,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Lars-Peter Clausen" <lars@metafoo.de>
Subject: Re: [PATCH 1/5] iio: light: noa1305: Simplify noa1305_read_raw()
Date: Sat, 20 Jul 2024 18:22:23 +0200 [thread overview]
Message-ID: <28fadb46-acbd-47d6-906d-2ac4b99db79d@denx.de> (raw)
In-Reply-To: <20240720142928.7a913229@jic23-huawei>
On 7/20/24 3:29 PM, Jonathan Cameron wrote:
> On Mon, 15 Jul 2024 20:28:55 +0200
> Marek Vasut <marex@denx.de> wrote:
>
>> The only channel this hardware supports is IIO_LIGHT, if the channel
>> is anything else, exit right away. The 'ret' variable is now always
>> only assigned by noa1305_measure(), do not initialize it anymore.
>> Update function parameter indent. No functional change.
>>
>> Signed-off-by: Marek Vasut <marex@denx.de>
> Hi Marek,
>
> One minor thing - please use a cover letter.
> Provides an obvious place for me to reply when picking things up and
> gives the whole series a meaningful title in patchwork.
I will keep that in mind, thanks for the reminder.
prev parent reply other threads:[~2024-07-20 16:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-15 18:28 [PATCH 1/5] iio: light: noa1305: Simplify noa1305_read_raw() Marek Vasut
2024-07-15 18:28 ` [PATCH 2/5] iio: light: noa1305: Assign val in noa1305_measure() Marek Vasut
2024-07-15 18:28 ` [PATCH 3/5] iio: light: noa1305: Use static table lookup of scale values Marek Vasut
2024-07-15 18:28 ` [PATCH 4/5] iio: light: noa1305: Report available " Marek Vasut
2024-07-15 18:28 ` [PATCH 5/5] iio: light: noa1305: Make integration time configurable Marek Vasut
2024-07-20 13:29 ` [PATCH 1/5] iio: light: noa1305: Simplify noa1305_read_raw() Jonathan Cameron
2024-07-20 16:22 ` Marek Vasut [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=28fadb46-acbd-47d6-906d-2ac4b99db79d@denx.de \
--to=marex@denx.de \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox