Linux IIO development
 help / color / mirror / Atom feed
From: Hans de Goede <hdegoede@redhat.com>
To: Jonathan LoBue <jlobue10@gmail.com>, Jonathan Cameron <jic23@kernel.org>
Cc: linux-iio@vger.kernel.org,
	"Andy Shevchenko" <andy.shevchenko@gmail.com>,
	"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
	"jagath jogj" <jagathjog1996@gmail.com>,
	"Luke Jones" <luke@ljones.dev>,
	"Denis Benato" <benato.denis96@gmail.com>,
	"Antheas Kapenekakis" <lkml@antheas.dev>,
	"Derek John Clark" <derekjohn.clark@gmail.com>
Subject: Re: [PATCH v6 0/2] Add bmi323 support for ASUS ROG ALLY
Date: Fri, 16 Feb 2024 19:45:07 +0100	[thread overview]
Message-ID: <298cba01-25a7-4c5f-92ee-e8d3254f2eca@redhat.com> (raw)
In-Reply-To: <CAF6rpDwZaCJOpLEYayVW8_aXQwKdpcLCDSRjbTNk1rr43EPriQ@mail.gmail.com>

Hi,

On 2/16/24 19:16, Jonathan LoBue wrote:
> From: Jonathan LoBue <jlobue10@gmail.com>
> 
> This patch series adds comments about a duplicate ACPI identifier
> between devices using bmc150 and bmi323. This series also adds the ACPI
> match table for devices using bmi323 to allow those devices to load the
> proper driver.
> 
> Changes since v5:
> - Updated patch titles
> - Add patch description to cover letter

I have just tested this on a Chuwi Hi13 tablet with
a BOSC0200 accel. I blacklisted the bmc150 driver so that
the bmi323 driver would load first. The bmi323 driver
"successfully" fails to probe and after manually loading
the bmc150 driver (to fake a module loading order of
the bmi323 driver loading before the bmc150) the accel
works properly.

So from my pov this series is good to go:

Tested-by: Hans de Goede <hdegoede@redhat.com>
Reviewed-by: Hans de Goede <hdegoede@redhat.com>

Regards,

Hans





  parent reply	other threads:[~2024-02-16 18:45 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-16 18:16 [PATCH v6 0/2] Add bmi323 support for ASUS ROG ALLY Jonathan LoBue
2024-02-16 18:22 ` [PATCH v6 1/2] iio: accel: bmc150: Document duplicate ACPI entries with bmi323 driver Jonathan LoBue
2024-02-16 18:23 ` [PATCH v6 2/2] iio: imu: bmi323: Add ACPI Match Table Jonathan LoBue
2024-02-16 18:45 ` Hans de Goede [this message]
2024-02-17 17:22   ` [PATCH v6 0/2] Add bmi323 support for ASUS ROG ALLY Jonathan Cameron
2024-02-17 17:28     ` Jonathan LoBue

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=298cba01-25a7-4c5f-92ee-e8d3254f2eca@redhat.com \
    --to=hdegoede@redhat.com \
    --cc=andy.shevchenko@gmail.com \
    --cc=benato.denis96@gmail.com \
    --cc=derekjohn.clark@gmail.com \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=jagathjog1996@gmail.com \
    --cc=jic23@kernel.org \
    --cc=jlobue10@gmail.com \
    --cc=linux-iio@vger.kernel.org \
    --cc=lkml@antheas.dev \
    --cc=luke@ljones.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox