From: "Ceclan, Dumitru" <mitrutzceclan@gmail.com>
To: Jonathan Cameron <jic23@kernel.org>
Cc: Dumitru Ceclan via B4 Relay
<devnull+dumitru.ceclan.analog.com@kernel.org>,
dumitru.ceclan@analog.com, Lars-Peter Clausen <lars@metafoo.de>,
Michael Hennerich <Michael.Hennerich@analog.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
David Lechner <dlechner@baylibre.com>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 1/6] dt-bindings: adc: ad7173: add support for ad411x
Date: Fri, 7 Jun 2024 10:29:24 +0300 [thread overview]
Message-ID: <29dfa7b1-8bf9-4996-b331-5de25bcbaa8c@gmail.com> (raw)
In-Reply-To: <20240606205813.65b342c4@jic23-huawei>
On 06/06/2024 22:58, Jonathan Cameron wrote:
> On Wed, 5 Jun 2024 09:54:31 +0300
> "Ceclan, Dumitru" <mitrutzceclan@gmail.com> wrote:
>
>> On 03/06/2024 23:00, Jonathan Cameron wrote:
>>> On Mon, 3 Jun 2024 12:46:10 +0300
>>> "Ceclan, Dumitru" <mitrutzceclan@gmail.com> wrote:
>>>
>>>> On 01/06/2024 21:35, Jonathan Cameron wrote:
>>>>> On Fri, 31 May 2024 22:42:27 +0300
>>>>> Dumitru Ceclan via B4 Relay <devnull+dumitru.ceclan.analog.com@kernel.org> wrote:
>>>>>
>>>>>> From: Dumitru Ceclan <dumitru.ceclan@analog.com>
>>
>> ...
>>
>>>>>> + Supported only by AD7172-2, AD7172-4, AD7175-2, AD7175-8, AD7177-2:
>>>>>> + 19: ((AVDD1 − AVSS)/5)+
>>>>>> + 20: ((AVDD1 − AVSS)/5)−
>>>>>
>>>>> That's what it says on the datasheet (so fine to copy that here) but I'm curious, what does
>>>>> that mean in practice? How can we have negative and postive signals of the difference
>>>>> between two power supply voltages where I'm fairly sure AVDD1 always greater than AVSS.
>>>>>
>>>>
>>>> I have not tested that as I do not have a model that supports this wired up.
>>>> If I had to guess they are the same signal but one should be connected to the
>>>> positive input, one to the negative input...but I could be wrong.
>>>
>>> If they are, then as far as I we are concerned is this one channel with two
>>> representations depending on whether it is 1st or 2nd in the list?
>>> Can we use one number and hide that detail in the driver?
>>>
>>> Seems odd though if that is the case.
>>>
>>> I guess if we find out later this is the case we can tighten the binding to
>>> enforce the right one instead of squashing them to one value, but that
>>> is a bit ugly. Any chance of digging out the info? If not we can go ahead
>>> but ideally answering things like this make a our life easier in the long run.
>>>
>>> Jonathan
>>>
>>
>> "(Avdd1/Avss)/5+ as positive input and (Avdd/Avss)/5- as negative
>> this is used for monitoring power supplies, the inputs must be selected in pair"
>> Perhaps it's an internal voltage divider...? I dunno
>>
>> So it seems like this cannot be used as a common mode voltage input.
>> I'll restrict the driver to only allow these inputs paired together
>> and rename the define for these selections.
> Most mysterious :) I'd be interested to know what value it reads
> back if you ever get the part.
>
My best guess now is that the reason for /5 is so that you can measure
the AVDD AVSS difference using the internal 2.5V reference.
So for AVDD 5V, AVSS 0V using the internal ref it would read 1V
I'll let you know if I test this
> Ah well, great to have gotten that extra detail even if it leaves
> more questions!
>
> Jonathan
>
next prev parent reply other threads:[~2024-06-07 7:29 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-31 19:42 [PATCH v4 0/6] Add support for AD411x Dumitru Ceclan via B4 Relay
2024-05-31 19:42 ` [PATCH v4 1/6] dt-bindings: adc: ad7173: add support for ad411x Dumitru Ceclan via B4 Relay
2024-06-01 18:35 ` Jonathan Cameron
2024-06-03 9:46 ` Ceclan, Dumitru
2024-06-03 20:00 ` Jonathan Cameron
2024-06-05 6:54 ` Ceclan, Dumitru
2024-06-06 19:58 ` Jonathan Cameron
2024-06-07 7:29 ` Ceclan, Dumitru [this message]
2024-05-31 19:42 ` [PATCH v4 2/6] iio: adc: ad7173: refactor channel configuration parsing Dumitru Ceclan via B4 Relay
2024-05-31 19:42 ` [PATCH v4 3/6] iio: adc: ad7173: refactor ain and vref selection Dumitru Ceclan via B4 Relay
2024-06-01 18:49 ` Jonathan Cameron
2024-06-03 13:00 ` Nuno Sá
2024-06-03 13:08 ` Ceclan, Dumitru
2024-06-03 16:00 ` David Lechner
2024-06-03 16:39 ` Ceclan, Dumitru
2024-05-31 19:42 ` [PATCH v4 4/6] iio: adc: ad7173: add support for special inputs Dumitru Ceclan via B4 Relay
2024-06-01 18:51 ` Jonathan Cameron
2024-05-31 19:42 ` [PATCH v4 5/6] iio: adc: ad7173: refactor device info structs Dumitru Ceclan via B4 Relay
2024-06-01 18:52 ` Jonathan Cameron
2024-05-31 19:42 ` [PATCH v4 6/6] iio: adc: ad7173: Add support for AD411x devices Dumitru Ceclan via B4 Relay
2024-06-01 19:19 ` Jonathan Cameron
2024-06-03 10:11 ` Ceclan, Dumitru
2024-06-03 20:07 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=29dfa7b1-8bf9-4996-b331-5de25bcbaa8c@gmail.com \
--to=mitrutzceclan@gmail.com \
--cc=Michael.Hennerich@analog.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=devnull+dumitru.ceclan.analog.com@kernel.org \
--cc=dlechner@baylibre.com \
--cc=dumitru.ceclan@analog.com \
--cc=jic23@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox