From: Sanjay Chitroda <sanjayembeddedse@gmail.com>
To: Jonathan Cameron <jic23@kernel.org>
Cc: dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org,
tglx@kernel.org, christophe.jaillet@wanadoo.fr, mingo@kernel.org,
nabijaczleweli@nabijaczleweli.xyz, kees@kernel.org,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 1/7] iio: ssp_sensors: cleanup codestyle warning
Date: Mon, 20 Apr 2026 09:58:53 +0530 [thread overview]
Message-ID: <2AA53122-CDDB-42C1-9674-C2C83478C1FA@gmail.com> (raw)
In-Reply-To: <20260419182848.7c6182b8@jic23-huawei>
On 19 April 2026 10:58:48 pm IST, Jonathan Cameron <jic23@kernel.org> wrote:
>On Wed, 15 Apr 2026 10:37:43 +0530
>Sanjay Chitroda <sanjayembeddedse@gmail.com> wrote:
>
>> From: Sanjay Chitroda <sanjayembeddedse@gmail.com>
>>
>> Reported by checkpatch:
>> FILE: drivers/iio/common/ssp_sensors/ssp_spi.c
>>
>> WARNING: Prefer __packed over __attribute__((__packed__))
>> +} __attribute__((__packed__));
>>
>> Signed-off-by: Sanjay Chitroda <sanjayembeddedse@gmail.com>
>> Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
>In interests of cutting down on how many patches are in flight
>I'm going to pick up at least the first few patches from your series.
>If another version is needed for others don't resend the ones I've
>picked up.
>
>Applied this one.
>
>thanks,
>
Understood, thanks.
This will also reduce overhead to maintain patches which are already good and reviewed by.
>> ---
>> drivers/iio/common/ssp_sensors/ssp_spi.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/iio/common/ssp_sensors/ssp_spi.c b/drivers/iio/common/ssp_sensors/ssp_spi.c
>> index 6c81c0385fb5..8c1e15d61db7 100644
>> --- a/drivers/iio/common/ssp_sensors/ssp_spi.c
>> +++ b/drivers/iio/common/ssp_sensors/ssp_spi.c
>> @@ -29,7 +29,7 @@ struct ssp_msg_header {
>> __le16 length;
>> __le16 options;
>> __le32 data;
>> -} __attribute__((__packed__));
>> +} __packed;
>>
>> struct ssp_msg {
>> u16 length;
>
next prev parent reply other threads:[~2026-04-20 4:28 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-15 5:07 [PATCH v6 0/7] iio: ssp_sensors: improve resource cleanup Sanjay Chitroda
2026-04-15 5:07 ` [PATCH v6 1/7] iio: ssp_sensors: cleanup codestyle warning Sanjay Chitroda
2026-04-19 17:28 ` Jonathan Cameron
2026-04-20 4:28 ` Sanjay Chitroda [this message]
2026-04-15 5:07 ` [PATCH v6 2/7] iio: ssp_sensors: cleanup codestyle check Sanjay Chitroda
2026-04-15 9:14 ` Andy Shevchenko
2026-04-19 17:33 ` Jonathan Cameron
2026-04-20 4:29 ` Sanjay Chitroda
2026-04-15 5:07 ` [PATCH v6 3/7] iio: ssp_sensors: factor out pending list add/remove helper(s) Sanjay Chitroda
2026-04-15 9:22 ` Andy Shevchenko
2026-04-15 9:25 ` Andy Shevchenko
2026-04-15 5:07 ` [PATCH v6 4/7] iio: ssp_sensors: drop duplicated wdt timer and work cleanup Sanjay Chitroda
2026-04-15 9:29 ` Andy Shevchenko
2026-04-19 12:32 ` Sanjay Chitroda
2026-04-15 5:07 ` [PATCH v6 5/7] iio: ssp_sensors: convert probe and teardown to devm-managed resources Sanjay Chitroda
2026-04-15 9:33 ` Andy Shevchenko
2026-04-19 12:33 ` Sanjay Chitroda
2026-04-19 17:39 ` Jonathan Cameron
2026-04-15 5:07 ` [PATCH v6 6/7] iio: ssp_sensors: Use dev_err_probe Sanjay Chitroda
2026-04-15 9:39 ` Andy Shevchenko
2026-04-19 12:40 ` Sanjay Chitroda
2026-04-15 5:07 ` [PATCH v6 7/7] iio: ssp_sensors: reuse embedded RX buffer for SPI transfers Sanjay Chitroda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2AA53122-CDDB-42C1-9674-C2C83478C1FA@gmail.com \
--to=sanjayembeddedse@gmail.com \
--cc=andy@kernel.org \
--cc=christophe.jaillet@wanadoo.fr \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=kees@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=nabijaczleweli@nabijaczleweli.xyz \
--cc=nuno.sa@analog.com \
--cc=tglx@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox