From: Sanjay Chitroda <sanjayembeddedse@gmail.com>
To: Andy Shevchenko <andriy.shevchenko@intel.com>
Cc: jic23@kernel.org, dlechner@baylibre.com, nuno.sa@analog.com,
andy@kernel.org, kees@kernel.org, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 1/5] iio: ssp_sensors: cleanup codestyle warning
Date: Tue, 07 Apr 2026 23:12:25 +0530 [thread overview]
Message-ID: <2D18BE15-3AC7-47DD-9430-E3ECB201EC84@gmail.com> (raw)
In-Reply-To: <adP8g8rYuXbfT3Um@ashevche-desk.local>
On 7 April 2026 12:03:39 am IST, Andy Shevchenko <andriy.shevchenko@intel.com> wrote:
>On Mon, Apr 06, 2026 at 01:38:48PM +0530, Sanjay Chitroda wrote:
>> From: Sanjay Chitroda <sanjayembeddedse@gmail.com>
>>
>> Reported by checkpatch:
>> FILE: drivers/iio/common/ssp_sensors/ssp_spi.c
>>
>> WARNING: Prefer __packed over __attribute__((__packed__))
>> +} __attribute__((__packed__));
>
>Do we need __packed to be there in the first place? Isn't it naturally aligned?
>
This structure isn't naturally aligned as in header structure u8 is followed by __le16 and __le32 fields.
Without packing, compiler inserts padding to satisfy alignment requirement.
next prev parent reply other threads:[~2026-04-07 17:42 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-06 8:08 [PATCH v5 0/5] iio: ssp_sensors: improve resource cleanup Sanjay Chitroda
2026-04-06 8:08 ` [PATCH v5 1/5] iio: ssp_sensors: cleanup codestyle warning Sanjay Chitroda
2026-04-06 18:33 ` Andy Shevchenko
2026-04-07 17:42 ` Sanjay Chitroda [this message]
2026-04-07 19:32 ` Andy Shevchenko
2026-04-06 8:08 ` [PATCH v5 2/5] iio: ssp_sensors: cleanup codestyle check Sanjay Chitroda
2026-04-06 8:08 ` [PATCH v5 3/5] iio: ssp_sensors: factor out pending list add/remove helpers Sanjay Chitroda
2026-04-06 20:04 ` Andy Shevchenko
2026-04-08 8:22 ` Sanjay Chitroda
[not found] ` <FA511CDD-1F98-4E66-BCE8-5156DBAF4359@gmail.com>
2026-04-08 11:36 ` Andy Shevchenko
2026-04-06 8:08 ` [PATCH v5 4/5] iio: ssp_sensors: use devm APIs for mutex and IRQ resources Sanjay Chitroda
2026-04-06 16:14 ` David Lechner
2026-04-07 12:42 ` Andy Shevchenko
2026-04-06 8:08 ` [PATCH v5 5/5] iio: ssp_sensors: reuse preallocated RX buffer for SPI transfers Sanjay Chitroda
2026-04-06 16:07 ` David Lechner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2D18BE15-3AC7-47DD-9430-E3ECB201EC84@gmail.com \
--to=sanjayembeddedse@gmail.com \
--cc=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=kees@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox