From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03AF4C433DB for ; Sat, 20 Feb 2021 16:57:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BE64760201 for ; Sat, 20 Feb 2021 16:57:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229817AbhBTQ46 (ORCPT ); Sat, 20 Feb 2021 11:56:58 -0500 Received: from vern.gendns.com ([98.142.107.122]:34166 "EHLO vern.gendns.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229766AbhBTQ46 (ORCPT ); Sat, 20 Feb 2021 11:56:58 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lechnology.com; s=default; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=rtReqm6BD8NSkzJ0Wi5T2+JHymMgDP+iJZyHo3wdEQ8=; b=N/oMDpnItwRnMQX8p1llCL4Lb5 06fFrczrCxCE0UVxM67Cpgzfm9bDaxCs/PeleokcZqpp/AJbQd9UcecaK+k4FSk1ueB/Kv2/pZ+M5 YjP3TiteYL8vMp0T0ACnOcQZwVlRX532BRWG4AGis9yIJj6n2QCuYKSzF5f9cZwP3TvVVIF7kz57S 5qwMOfBCnZj1ZcQVTl11zWp7H7lUKXojAKJ0YdzrBaC4nkogK5ofzR3A4o7/39CqPuNagNnPweLYQ 3mSmIcP80Psuxe7AuKTzSL7JwtQx2AneZr+s0sj98qFvTJw2MwqisFZ40Ee+3HwIrK9mhzwNGyazD ODr55F3A==; Received: from 108-198-5-147.lightspeed.okcbok.sbcglobal.net ([108.198.5.147]:57830 helo=[192.168.0.134]) by vern.gendns.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.93) (envelope-from ) id 1lDVYE-0005DO-Qy; Sat, 20 Feb 2021 11:56:14 -0500 Subject: Re: [PATCH v8 12/22] counter: Rename counter_count_function to counter_function To: Jonathan Cameron , William Breathitt Gray Cc: kernel@pengutronix.de, linux-stm32@st-md-mailman.stormreply.com, a.fatoum@pengutronix.de, kamel.bouhara@bootlin.com, gwendal@chromium.org, alexandre.belloni@bootlin.com, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, syednwaris@gmail.com, patrick.havelange@essensium.com, fabrice.gasnier@st.com, mcoquelin.stm32@gmail.com, alexandre.torgue@st.com, o.rempel@pengutronix.de References: <355aaaaf44b36c5de1704e4074a4671abcb9699d.1613131238.git.vilhelm.gray@gmail.com> <20210214171340.3cc7b686@archlinux> From: David Lechner Message-ID: <2b6913ac-0802-f83e-06ba-e89d5318dbd7@lechnology.com> Date: Sat, 20 Feb 2021 10:56:13 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20210214171340.3cc7b686@archlinux> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - vern.gendns.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - lechnology.com X-Get-Message-Sender-Via: vern.gendns.com: authenticated_id: davidmain+lechnology.com/only user confirmed/virtual account not confirmed X-Authenticated-Sender: vern.gendns.com: davidmain@lechnology.com X-Source: X-Source-Args: X-Source-Dir: Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On 2/14/21 11:13 AM, Jonathan Cameron wrote: > On Fri, 12 Feb 2021 21:13:36 +0900 > William Breathitt Gray wrote: > >> The phrase "Counter Count function" is verbose and unintentionally >> implies that function is a Count extension. This patch adjusts the >> Counter subsystem code to use the more direct "Counter function" phrase >> to make the intent of this code clearer. The phrase "Count action" is >> adjusted herein as well for the same reason. >> >> Cc: Syed Nayyar Waris >> Cc: Patrick Havelange >> Cc: Kamel Bouhara >> Cc: Fabrice Gasnier >> Cc: Maxime Coquelin >> Cc: Alexandre Torgue >> Cc: David Lechner >> Signed-off-by: William Breathitt Gray > > I agree this makes sense in the counter core code, but in the drivers > it may not be quite so obvious we are talking about a counter function > given some of the bits of hardware do a number of other things. > > I guess up to the various driver maintainers on whether they > think the new meaning is clear enough! > > Jonathan > TBH, I think "counter count function" makes more sense to me.