From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 15D33C83F11 for ; Sat, 26 Aug 2023 02:03:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231716AbjHZCDH (ORCPT ); Fri, 25 Aug 2023 22:03:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40554 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231717AbjHZCCy (ORCPT ); Fri, 25 Aug 2023 22:02:54 -0400 Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 13A652129 for ; Fri, 25 Aug 2023 19:02:51 -0700 (PDT) Received: from kwepemi500008.china.huawei.com (unknown [172.30.72.56]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4RXg6374ZKz1L9Fn; Sat, 26 Aug 2023 10:01:15 +0800 (CST) Received: from [10.67.109.254] (10.67.109.254) by kwepemi500008.china.huawei.com (7.221.188.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.31; Sat, 26 Aug 2023 10:02:48 +0800 Message-ID: <2b9c3a6d-8d1d-7815-c4ea-59ff77654e3c@huawei.com> Date: Sat, 26 Aug 2023 10:02:47 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.0 Subject: Re: [PATCH -next 1/4] iio: adc: at91_adc: Use devm_clk_get_enabled() helper function Content-Language: en-US To: Jonathan Cameron CC: , , , , , , , , , , , , References: <20230825105746.2999548-1-ruanjinjie@huawei.com> <20230825105746.2999548-2-ruanjinjie@huawei.com> <20230825135015.481d0aff@jic23-huawei> From: Ruan Jinjie In-Reply-To: <20230825135015.481d0aff@jic23-huawei> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.67.109.254] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To kwepemi500008.china.huawei.com (7.221.188.139) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On 2023/8/25 20:50, Jonathan Cameron wrote: > te patch moving to > devm_request_irq() as then the exit paths will become much simpler and you > can also move to return dev_err_probe() save a few pointless lines of code > and give the benefit of debug info for deferred return codes. Right!I'll cleanup these together in v2.