From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Cixi Geng <gengcixi@gmail.com>,
jic23@kernel.org, lars@metafoo.de, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, orsonzhai@gmail.com,
baolin.wang7@gmail.com, zhang.lyra@gmail.com,
yuming.zhu1@unisoc.com
Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH V4 1/7] dt-bindings:iio:adc: add sprd,ump9620-adc dt-binding
Date: Wed, 20 Apr 2022 09:01:51 +0200 [thread overview]
Message-ID: <2bcf42e0-c58e-99f7-b667-8c212022ff19@linaro.org> (raw)
In-Reply-To: <20220419142458.884933-2-gengcixi@gmail.com>
On 19/04/2022 16:24, Cixi Geng wrote:
> - nvmem-cell-names:
> - items:
> - - const: big_scale_calib
> - - const: small_scale_calib
> + nvmem-cell-names: true
> +> +if:
Better to include it under "allOf:" so next time you need more of such
if-then, you do not need to change indentation. But anyway looks good:
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> + not:
> + properties:
> + compatible:
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-04-20 7:02 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-19 14:24 [PATCH V4 0/7] iio: adc: sc27xx: adjust structure and add PMIC's support Cixi Geng
2022-04-19 14:24 ` [PATCH V4 1/7] dt-bindings:iio:adc: add sprd,ump9620-adc dt-binding Cixi Geng
2022-04-20 7:01 ` Krzysztof Kozlowski [this message]
2022-04-24 17:21 ` Jonathan Cameron
2022-04-19 14:24 ` [PATCH V4 2/7] iio: adc: sc27xx: fix read big scale voltage not right Cixi Geng
2022-04-24 17:00 ` Jonathan Cameron
2022-04-19 14:24 ` [PATCH V4 3/7] iio: adc: Fine tune the scale calibration values Cixi Geng
2022-04-24 17:01 ` Jonathan Cameron
2022-04-24 17:28 ` Jonathan Cameron
2022-04-19 14:24 ` [PATCH V4 4/7] iio: adc: sc27xx: structure adjustment and optimization Cixi Geng
2022-04-19 14:24 ` [PATCH V4 5/7] iio: adc: refactor some functions for support more PMiCs Cixi Geng
2022-04-24 17:30 ` Jonathan Cameron
2022-04-19 14:24 ` [PATCH V4 6/7] iio: adc: sc27xx: add support for PMIC sc2720 and sc2721 Cixi Geng
2022-04-19 14:24 ` [PATCH V4 7/7] iio: adc: sc27xx: add support for PMIC sc2730 Cixi Geng
2022-04-24 17:34 ` [PATCH V4 0/7] iio: adc: sc27xx: adjust structure and add PMIC's support Jonathan Cameron
2022-04-29 4:25 ` Cixi Geng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2bcf42e0-c58e-99f7-b667-8c212022ff19@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=baolin.wang7@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=gengcixi@gmail.com \
--cc=jic23@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=orsonzhai@gmail.com \
--cc=robh+dt@kernel.org \
--cc=yuming.zhu1@unisoc.com \
--cc=zhang.lyra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox