From: Jonathan Cameron <jic23@kernel.org>
To: Akinobu Mita <akinobu.mita@gmail.com>, linux-iio@vger.kernel.org
Cc: Crestez Dan Leonard <leonard.crestez@intel.com>,
Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>
Subject: Re: [PATCH] iio: max44000: correct value in illuminance_integration_time_available
Date: Fri, 30 Dec 2016 20:22:26 +0000 [thread overview]
Message-ID: <2c45861e-e813-624f-03f8-88b0bc95e60d@kernel.org> (raw)
In-Reply-To: <1482945396-18604-1-git-send-email-akinobu.mita@gmail.com>
On 28/12/16 17:16, Akinobu Mita wrote:
> According to the datasheet, the shortest available integration time for
> ALS ADC conversion is 1.5625ms but illuminance_integration_time_available
> sysfs file shows wrong value.
>
> Cc: Crestez Dan Leonard <leonard.crestez@intel.com>
> Cc: Jonathan Cameron <jic23@kernel.org>
> Cc: Hartmut Knaack <knaack.h@gmx.de>
> Cc: Lars-Peter Clausen <lars@metafoo.de>
> Cc: Peter Meerwald-Stadler <pmeerw@pmeerw.net>
> Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
Good find. Applied to the fixes-togreg-post-rc1 branch of iio.git
and marked for stable with a fixes tag added. It might apply cleanly
along the way, but the original bug was quite a few patches back.
Jonathan
> ---
> drivers/iio/light/max44000.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/light/max44000.c b/drivers/iio/light/max44000.c
> index a144ca3..81bd8e8 100644
> --- a/drivers/iio/light/max44000.c
> +++ b/drivers/iio/light/max44000.c
> @@ -113,7 +113,7 @@ static const char max44000_int_time_avail_str[] =
> "0.100 "
> "0.025 "
> "0.00625 "
> - "0.001625";
> + "0.0015625";
>
> /* Available scales (internal to ulux) with pretty manual alignment: */
> static const int max44000_scale_avail_ulux_array[] = {
>
prev parent reply other threads:[~2016-12-30 20:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-28 17:16 [PATCH] iio: max44000: correct value in illuminance_integration_time_available Akinobu Mita
2016-12-30 20:22 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2c45861e-e813-624f-03f8-88b0bc95e60d@kernel.org \
--to=jic23@kernel.org \
--cc=akinobu.mita@gmail.com \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=leonard.crestez@intel.com \
--cc=linux-iio@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).