From: Matti Vaittinen <mazziesaccount@gmail.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>,
Jonathan Cameron <jic23@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Daniel Scally <djrscally@gmail.com>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Danilo Krummrich <dakr@kernel.org>,
Claudiu Manoil <claudiu.manoil@nxp.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [PATCH v6 02/10] property: Add functions to iterate named child
Date: Thu, 13 Mar 2025 08:42:18 +0200 [thread overview]
Message-ID: <2cb99c3d-6ea5-4c47-9e6c-d1a3966ad7ff@gmail.com> (raw)
In-Reply-To: <Z872bHMRtSglB8pf@smile.fi.intel.com>
Hi Andy,
Thanks for the review.
On 10/03/2025 16:25, Andy Shevchenko wrote:
> On Mon, Mar 10, 2025 at 02:55:53PM +0200, Matti Vaittinen wrote:
...
>> +#define fwnode_for_each_named_child_node(fwnode, child, name) \
>> + fwnode_for_each_child_node(fwnode, child) \
>
> One TAB too much.
>
>> + if (!fwnode_name_eq(child, name)) { } else
>
> Ditto.
>
> Note, I believe this won't get v6.15-rc1, so there will be for_each_if()
> available and these will become
I'll use for_each_if() if I'll have to rebase this to the v6.15-rc1.
> But see above the proposed additional patch that you may include in your next
> version.
Seems like you sent it as it's own series. I believe it's better that way.
Yours,
-- Matti
next prev parent reply other threads:[~2025-03-13 6:42 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-10 12:53 [PATCH v6 00/10] Support ROHM BD79124 ADC Matti Vaittinen
2025-03-10 12:54 ` [PATCH v6 01/10] dt-bindings: ROHM BD79124 ADC/GPO Matti Vaittinen
2025-03-10 12:55 ` [PATCH v6 02/10] property: Add functions to iterate named child Matti Vaittinen
2025-03-10 14:25 ` Andy Shevchenko
2025-03-10 20:19 ` Jonathan Cameron
2025-03-13 6:42 ` Matti Vaittinen [this message]
2025-03-10 14:51 ` Andy Shevchenko
2025-03-10 18:12 ` Sakari Ailus
2025-03-10 12:56 ` [PATCH v6 03/10] iio: adc: add helpers for parsing ADC nodes Matti Vaittinen
2025-03-10 12:56 ` [PATCH v6 04/10] iio: adc: rzg2l_adc: Use adc-helpers Matti Vaittinen
2025-03-10 20:22 ` Jonathan Cameron
2025-03-10 12:56 ` [PATCH v6 05/10] iio: adc: sun20i-gpadc: " Matti Vaittinen
2025-03-10 20:23 ` Jonathan Cameron
2025-03-10 12:56 ` [PATCH v6 06/10] iio: adc: Support ROHM BD79124 ADC Matti Vaittinen
2025-03-10 20:26 ` Jonathan Cameron
2025-03-10 12:56 ` [PATCH v6 07/10] MAINTAINERS: Add IIO ADC helpers Matti Vaittinen
2025-03-10 12:57 ` [PATCH v6 08/10] MAINTAINERS: Add ROHM BD79124 ADC/GPO Matti Vaittinen
2025-03-10 20:27 ` [PATCH v6 00/10] Support ROHM BD79124 ADC Jonathan Cameron
2025-03-11 5:49 ` Matti Vaittinen
2025-03-15 18:28 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2cb99c3d-6ea5-4c47-9e6c-d1a3966ad7ff@gmail.com \
--to=mazziesaccount@gmail.com \
--cc=andrew+netdev@lunn.ch \
--cc=andriy.shevchenko@linux.intel.com \
--cc=claudiu.manoil@nxp.com \
--cc=conor+dt@kernel.org \
--cc=dakr@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=djrscally@gmail.com \
--cc=edumazet@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matti.vaittinen@fi.rohmeurope.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rafael@kernel.org \
--cc=robh@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).