Re: [PATCH 08/16] iio: light: adjd_s311: Use iio_push_to_buffers_with_ts() to allow source size runtime check

[Matti Vaittinen <mazziesaccount@gmail.com>]

On 02/08/2025 19:44, Jonathan Cameron wrote:
> From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> 
> Also move the structure used as the source to the stack as it is only 16
> bytes and not the target of an DMA or similar.
> 
> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> ---
>   drivers/iio/light/adjd_s311.c | 12 ++++++------
>   1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/iio/light/adjd_s311.c b/drivers/iio/light/adjd_s311.c
> index cf96e3dd8bc6..edb3d9dc8bed 100644
> --- a/drivers/iio/light/adjd_s311.c
> +++ b/drivers/iio/light/adjd_s311.c
> @@ -54,10 +54,6 @@
>   
>   struct adjd_s311_data {
>   	struct i2c_client *client;
> -	struct {
> -		s16 chans[4];
> -		aligned_s64 ts;
> -	} scan;
>   };
>   
>   enum adjd_s311_channel_idx {
> @@ -120,6 +116,10 @@ static irqreturn_t adjd_s311_trigger_handler(int irq, void *p)
>   	struct adjd_s311_data *data = iio_priv(indio_dev);
>   	s64 time_ns = iio_get_time_ns(indio_dev);
>   	int i, j = 0;
> +	struct {
> +		s16 chans[4];
> +		aligned_s64 ts;
> +	} scan = { };
>   
>   	int ret = adjd_s311_req_data(indio_dev);
>   	if (ret < 0)
> @@ -131,10 +131,10 @@ static irqreturn_t adjd_s311_trigger_handler(int irq, void *p)
>   		if (ret < 0)
>   			goto done;
>   
> -		data->scan.chans[j++] = ret & ADJD_S311_DATA_MASK;
> +		scan.chans[j++] = ret & ADJD_S311_DATA_MASK;
>   	}
>   
> -	iio_push_to_buffers_with_timestamp(indio_dev, &data->scan, time_ns);
> +	iio_push_to_buffers_with_ts(indio_dev, &scan, sizeof(scan), time_ns);
>   
>   done:
>   	iio_trigger_notify_done(indio_dev->trig);

Reviewed-by: Matti Vaittinen <mazziesaccount@gmail.com>