From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF6EEC433FE for ; Wed, 16 Mar 2022 16:36:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1350287AbiCPQhN (ORCPT ); Wed, 16 Mar 2022 12:37:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41066 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239916AbiCPQhM (ORCPT ); Wed, 16 Mar 2022 12:37:12 -0400 Received: from smtp-relay-internal-0.canonical.com (smtp-relay-internal-0.canonical.com [185.125.188.122]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3C96F66FA1 for ; Wed, 16 Mar 2022 09:35:58 -0700 (PDT) Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-0.canonical.com (Postfix) with ESMTPS id 9890F3F325 for ; Wed, 16 Mar 2022 16:35:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1647448556; bh=FN6zG2dC0IqxltRJmG+dxaBsreyz6dzWc1lR1WuSTgg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=EXydiQQbRtbmfMfMQaI24mFiiKVIecDk25GD8YISiz/sjs4ejGWYTOB645EeJqNb0 JDDl991h5VwVeaI7V9xr0x/Uw94pMtVtWuIZfA9q06ylbKypRCuRbqUw2N6/3/sAVm 6wMNo4kjudyw7B99mMndPmYbMeHcTb50giJ4Pz78lLNvOVigAQ48QAc9jVolRMEiUO y+FsSWIbPlKa1t1xDqHoCj4WPfDxguGvsLKBbRaeh9mmp4I2STAsJQ6dybgBqGH5rg dUWnwwRmadX7JuQA6JwQDMqrmLlRVRG/HBwltz4dnTF+2oGu8c53DnZ05Nd/hhWlNr ke5GxqbZp5M6Q== Received: by mail-wm1-f70.google.com with SMTP id k26-20020a05600c0b5a00b0038c6c41159bso1262294wmr.0 for ; Wed, 16 Mar 2022 09:35:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=FN6zG2dC0IqxltRJmG+dxaBsreyz6dzWc1lR1WuSTgg=; b=jcD5rHs2yKMWjjPcXtzO1tS8Iv3Dn8cJI6HAMe8WS9wsB1pry2aIcmGjERSi1/m4du UjIvDaCotAXIqUzCuI0AC2jlyx2l3Qx9W5Pg4R3RiXz+SNWkAmqy3lRW68VDMvXk0r/i u0zLSOTSzAiEMbKr+AuQad31SmTZlKWQIgyk6tPtnEp4Wu5BWpa/eEZFZgOdlAAeC73Q hjh/o2SlvMIT8RP0pOZq/u60138taadvQSF8e0lQexkNQdHwmDjdsTezu4sNChX5YmZM MS+TrFhC7PT4mCTI4TABKbrzJwxqEw3Nbj6wI8DndvhfLshQ0srCE1mE2s3rev6DISUa mXUg== X-Gm-Message-State: AOAM530y4YVpFb9RhHVNT2KAw61IbCYmE/K0dCAUTHD5Ac3Xv9UBMNk4 b7gZXcTUEtcAOh3v7yKNd4Lgl03E5sLbQ8rgAZrWsSwh9I89jhCsVIZ/udrNF/nz1LJa0U1f6tn PngeKejPiDD7pRDD5E/0scWz3SJRWUQqbEBqAJQ== X-Received: by 2002:adf:e2cb:0:b0:203:7564:1076 with SMTP id d11-20020adfe2cb000000b0020375641076mr600101wrj.199.1647448556135; Wed, 16 Mar 2022 09:35:56 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxVzUE71PYe2vyYegyHpKm8lEtDhuWhcP+csFOqL5Hf16cQSLcM9FjV7jTjqEvHk2m5Hgibhw== X-Received: by 2002:adf:e2cb:0:b0:203:7564:1076 with SMTP id d11-20020adfe2cb000000b0020375641076mr600080wrj.199.1647448555945; Wed, 16 Mar 2022 09:35:55 -0700 (PDT) Received: from [192.168.0.17] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.googlemail.com with ESMTPSA id bg20-20020a05600c3c9400b0037fa5c422c8sm6156246wmb.48.2022.03.16.09.35.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 16 Mar 2022 09:35:55 -0700 (PDT) Message-ID: <2f48ac79-23fa-85ea-c4e2-d03cc2a2b5ac@canonical.com> Date: Wed, 16 Mar 2022 17:35:53 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v12 4/9] dt-bindings: iio: adc: document qcom-spmi-rradc Content-Language: en-US To: Caleb Connolly , Jonathan Cameron , Lars-Peter Clausen , Rob Herring , Andy Gross , Bjorn Andersson , Lee Jones , Stephen Boyd , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org Cc: sumit.semwal@linaro.org, amit.pundir@linaro.org, john.stultz@linaro.org, Rob Herring References: <20220316142313.92371-1-caleb.connolly@linaro.org> <20220316142313.92371-5-caleb.connolly@linaro.org> From: Krzysztof Kozlowski In-Reply-To: <20220316142313.92371-5-caleb.connolly@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On 16/03/2022 15:23, Caleb Connolly wrote: > Add dt-binding docs for the Qualcomm SPMI RRADC found in PMICs like > PMI8998 and PMI8994 > > Signed-off-by: Caleb Connolly > Reviewed-by: Rob Herring > --- > .../bindings/iio/adc/qcom,spmi-rradc.yaml | 54 +++++++++++++++++++ > 1 file changed, 54 insertions(+) > create mode 100644 Documentation/devicetree/bindings/iio/adc/qcom,spmi-rradc.yaml > > diff --git a/Documentation/devicetree/bindings/iio/adc/qcom,spmi-rradc.yaml b/Documentation/devicetree/bindings/iio/adc/qcom,spmi-rradc.yaml > new file mode 100644 > index 000000000000..11d47c46a48d > --- /dev/null > +++ b/Documentation/devicetree/bindings/iio/adc/qcom,spmi-rradc.yaml > @@ -0,0 +1,54 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/iio/adc/qcom,spmi-rradc.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Qualcomm's SPMI PMIC Round Robin ADC > + > +maintainers: > + - Caleb Connolly > + > +description: | > + The Qualcomm SPMI Round Robin ADC (RRADC) provides interface to clients to read the > + voltage, current and temperature for supported peripherals such as the battery thermistor > + die temperature, charger temperature, USB and DC input voltage / current and battery ID > + resistor. Please wrap at 80. It's still in the coding style and there is no readability increase by using 100. Same goes to other descriptions here. > + > +properties: > + compatible: > + enum: > + - qcom,pmi8998-rradc > + - qcom,pm660-rradc > + > + reg: > + description: rradc base address and length in the SPMI PMIC register map Obvious description, remove it. Best regards, Krzysztof