From: Lars-Peter Clausen <lars@metafoo.de>
To: Jonathan Cameron <jic23@kernel.org>, linux-iio@vger.kernel.org
Cc: Andy Shevchenko <andy.shevchenko@gmail.com>,
Jonathan Cameron <Jonathan.Cameron@huawei.com>
Subject: Re: [PATCH 01/12] iio:dac:ad5755: Switch to generic firmware properties.
Date: Sun, 28 Nov 2021 20:40:33 +0100 [thread overview]
Message-ID: <2f6dad36-45d6-9acd-ff1d-edf925f99b88@metafoo.de> (raw)
In-Reply-To: <20211128192635.2724359-2-jic23@kernel.org>
On 11/28/21 8:26 PM, Jonathan Cameron wrote:
> static int ad5755_probe(struct spi_device *spi)
> {
> @@ -751,8 +736,8 @@ static int ad5755_probe(struct spi_device *spi)
>
> mutex_init(&st->lock);
>
> - if (spi->dev.of_node)
> - pdata = ad5755_parse_dt(&spi->dev);
> + if (dev_fwnode(&spi->dev))
> + pdata = ad5755_parse_fw(&spi->dev);
> else
> pdata = spi->dev.platform_data;
Considering that it is possible to supply fw_node data through platform
files we as well just completely drop platform_data support. And make
the platform data struct local to this file.
next prev parent reply other threads:[~2021-11-28 19:42 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-28 19:26 [PATCH 00/12] IIO: Mroe of to generic fw conversions Jonathan Cameron
2021-11-28 19:26 ` [PATCH 01/12] iio:dac:ad5755: Switch to generic firmware properties Jonathan Cameron
2021-11-28 19:40 ` Lars-Peter Clausen [this message]
2021-12-04 16:52 ` Jonathan Cameron
2021-11-28 19:26 ` [PATCH 02/12] iio:dac:ad5758: Drop unused of specific headers Jonathan Cameron
2021-11-28 19:26 ` [PATCH 03/12] iio:dac:dpot-dac: Swap of.h for mod_devicetable.h Jonathan Cameron
2021-11-28 21:46 ` Peter Rosin
2021-11-28 19:26 ` [PATCH 04/12] iio:dac:lpc18xx_dac: Swap from of* to mod_devicetable.h Jonathan Cameron
2021-11-28 19:26 ` [PATCH 05/12] iio:pot:mcp41010: Switch to generic firmware properties Jonathan Cameron
2021-11-28 19:26 ` [PATCH 06/12] iio:light:cm3605: " Jonathan Cameron
2021-11-30 0:24 ` Linus Walleij
2021-11-28 19:26 ` [PATCH 07/12] iio:adc:max9611: " Jonathan Cameron
2021-11-28 19:26 ` [PATCH 08/12] iio:adc:mcp3911: " Jonathan Cameron
2021-11-28 19:26 ` [PATCH 09/12] iio:adc:ti-adc12138: " Jonathan Cameron
2021-11-28 19:26 ` [PATCH 10/12] iio:adc:envelope-detector: Switch from of headers to mod_devicetable.h Jonathan Cameron
2021-11-28 21:48 ` Peter Rosin
2021-11-28 19:26 ` [PATCH 11/12] iio:adc:ti-ads124s08: Drop dependency on OF Jonathan Cameron
2021-11-28 19:26 ` [PATCH 12/12] iio:adc/dac:Kconfig: Update to drop OF dependencies Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2f6dad36-45d6-9acd-ff1d-edf925f99b88@metafoo.de \
--to=lars@metafoo.de \
--cc=Jonathan.Cameron@huawei.com \
--cc=andy.shevchenko@gmail.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).