From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f44.google.com (mail-ot1-f44.google.com [209.85.210.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E0FC930F816 for ; Sat, 16 May 2026 19:35:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778960113; cv=none; b=ENQPbLiw1oRux7t1ug5UAmQzxpofhmQnj68Q35lNZU94019NRZctt+4BBBW8d/X9Fn5W4Y7fU1px+Rt+d1K2TfEFQuZhYHuhvOTahvtqjmbzbujhhWK1v/P8qXOtGbJr1HaTEFv8V4O8ub8VjRa6E1FB2eaGqWjsAKYJ5PZz+Ek= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778960113; c=relaxed/simple; bh=NnjdJ0VTzldu49W5mcdmVmQl1rEFGjOR7UXnupRT89o=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=CNUl7D1DzcUxLKOAFkDz56XisPAKL+4DjgZL7B0iHWv1uBl1vRsDd7clLpjpwJdu8xeWT7sqmh8Bxsq74KNXnvCDmiWHk3v3yRLgTb5rPEe4Yjk306AIfemJkjqezIGuX1Y2Io+mNsv5UZ00AnAgTGBCcVfFJtCIzsiXaeGAyQ0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20251104.gappssmtp.com header.i=@baylibre-com.20251104.gappssmtp.com header.b=ycSFdIHX; arc=none smtp.client-ip=209.85.210.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20251104.gappssmtp.com header.i=@baylibre-com.20251104.gappssmtp.com header.b="ycSFdIHX" Received: by mail-ot1-f44.google.com with SMTP id 46e09a7af769-7dcdaf06498so650668a34.2 for ; Sat, 16 May 2026 12:35:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20251104.gappssmtp.com; s=20251104; t=1778960111; x=1779564911; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=2i7S9wo1ePdNkbO172mKq17H2QCBIBfTWKgSltqMeIg=; b=ycSFdIHXs9K+m3s4gmn0h5deTpkDt9ZhNq9w2hQhZ17c57ZrA1XU+xgHxu79eyPdH3 /GCKWJKltawnEfsWVBnGgkyL3i9u6ZXxZPAkzJkcTNBCaHQm+nkMNUZFrMiqx3cnL7i0 qApuwisVDLguS2/wyn4jLE3cDIIOsWJHaKfSUMcg89FTkPLCKcK5V9BfQehB1pFjJkjs pMX1XRSxyUFqyr4X81SgiJ0YJ9icqJQYUe/k4EA0Dm+JtVjux97j7Cpjr+5ku4dGXX83 Sq0kuUjLH9ZKe2OSDdqpXNyfhHauBOSAfEgfOcfNOE+swwEHH8BxM19a03ziVhc/la1b +0OQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778960111; x=1779564911; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=2i7S9wo1ePdNkbO172mKq17H2QCBIBfTWKgSltqMeIg=; b=HpOSfYzJFR0dmZCyeLORMB574MnifMxa4UPXGrEgX7qlJhcg5UWgtfatcRUeaP8OpN lUbLYakZ41RpU/aTI8EckcN/tsJMnrvgJ7Na6Yp7jEeUrRDEZ/HXhll2unBFBpUDUK57 bkSrARvIQOgQcKTSqsxXi8kXa2ndaWwnb2CG7PNBPnOM9hnHamieF9h1IXmwaHMVp7bf U2D7nbAdZ/nQxMh86ds2UhUyH3rSJr/8ozInuvXr0jaswBVYxPCa2IrcYboXVtudq9as EmRMqwgw/tyOFJcpQkLFzmVE1l2UfLBZh7N7/EQvzN72te0cjUq8l8Bxa/+Uc9lO8HV2 fhww== X-Gm-Message-State: AOJu0Yxbsy7Q74VuxSyZp9efAww4OBJexXWPYO0elDUVDUmiHWMnWJwi 8exNe5x1cI8rKqxBwo9SG+fGEK2YZ0IpP20zq9vvC4QRgWBW/P4YaFdnmgNe59UBtLE= X-Gm-Gg: Acq92OEMZ/W65dJ+i4av3ODv2ajKJKnQ5rzLtmXw0QgEREGOGOThA/eBcZE8RkR05ID fmpRp6LZnebafJhLKo6j8/TQ+AodRRCORRgx2fHUmK7o3QBCwVSHwigRAZmdx0pliGq3G/mBqug oSdt+hrPzervDua2LkdOWy3IloH9LNnn1DhNJ8CxJY+d+hg0DyPGVn4mjs8tAZMEg2aG1Co/hpc MHuRlqrdVXmqMgh2kHMEYkw+lFcCQiUczuWezWFvLKEILU8meZj75qARiMzWZic45X8cO9p3gra JaPR+H4wt5VZQENzzVJ9nUyLX+8aEKvWHkMJffiA2nHg3yf0lbTl6oVtoDhtjPoo/kpuhysaWlj 7HcsfNJFJywJMN9/AeKoaTecFKI78dt8DrWAWUpiiA5+TKRJBbepuPf4vPVVlqO2mjcGyH4x7ol 4EjNpAU+17p2EQTp4QUcgwIL0pAro5oJZBOnl5nD5cS6kR7A0etAcjJV1EHnUAQxTlRWzIh0l0k A== X-Received: by 2002:a05:6820:2017:b0:694:a2c9:2d50 with SMTP id 006d021491bc7-69c9c07d4fbmr5938765eaf.59.1778960110874; Sat, 16 May 2026 12:35:10 -0700 (PDT) Received: from ?IPV6:2600:8803:e7e4:500:b36d:bd18:7c02:29e2? ([2600:8803:e7e4:500:b36d:bd18:7c02:29e2]) by smtp.gmail.com with ESMTPSA id 006d021491bc7-69d048b3c51sm3071760eaf.11.2026.05.16.12.35.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 16 May 2026 12:35:09 -0700 (PDT) Message-ID: <2f74e76e-b066-40ac-9cb4-c75137c9825d@baylibre.com> Date: Sat, 16 May 2026 14:35:09 -0500 Precedence: bulk X-Mailing-List: linux-iio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/3] iio: dac: Add AD5529R DAC driver support To: Janani Sunil , Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , =?UTF-8?Q?Nuno_S=C3=A1?= , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Philipp Zabel , Jonathan Corbet , Shuah Khan Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, Janani Sunil References: <20260508-ad5529r-driver-v2-0-e315441685d7@analog.com> <20260508-ad5529r-driver-v2-2-e315441685d7@analog.com> Content-Language: en-US From: David Lechner In-Reply-To: <20260508-ad5529r-driver-v2-2-e315441685d7@analog.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 5/8/26 6:55 AM, Janani Sunil wrote: > Add support for AD5529R 16-channel, 12/16 bit Digital to Analog Converter > ... > +#define AD5529R_DAC_CHANNEL(chan, bits) { \ > + .type = IIO_VOLTAGE, \ > + .indexed = 1, \ > + .output = 1, \ > + .channel = (chan), \ > + .info_mask_separate = BIT(IIO_CHAN_INFO_RAW) | \ > + BIT(IIO_CHAN_INFO_SCALE), \ > + .scan_type = { \ > + .sign = 'u', \ This field has a new name `.format`. > + .realbits = (bits), \ > + .storagebits = 16, \ > + }, \ > +} > +static struct regmap *ad5529r_get_regmap(struct ad5529r_state *st, unsigned int reg) > +{ > + if (reg <= AD5529R_8BIT_REG_MAX) > + return st->regmap_8bit; > + > + return st->regmap_16bit; > +} Another way we have done this is make custom read/write functions for the regmap itself so that we don't have to have two regmaps. > + > +static int ad5529r_debugfs_reg_read(struct ad5529r_state *st, unsigned int reg, > + unsigned int *val) > +{ > + return regmap_read(ad5529r_get_regmap(st, reg), reg, val); > +} > + > +static int ad5529r_debugfs_reg_write(struct ad5529r_state *st, unsigned int reg, > + unsigned int val) > +{ > + return regmap_write(ad5529r_get_regmap(st, reg), reg, val); > +} Would be more logical to move these closer to the struct that references them. (I snipped a bunch of functions here) > + > +static int ad5529r_reg_access(struct iio_dev *indio_dev, > + unsigned int reg, > + unsigned int writeval, > + unsigned int *readval) > +{ > + struct ad5529r_state *st = iio_priv(indio_dev); > + > + if (!readval) Might as well swap these and avoid the !. > + return ad5529r_debugfs_reg_write(st, reg, writeval); > + > + return ad5529r_debugfs_reg_read(st, reg, readval); > +} > +