From: Jonathan Cameron <jic23@kernel.org>
To: Alison Schofield <amsfield22@gmail.com>
Cc: afd@ti.com, mtitinger@baylibre.com, knaack.h@gmx.de,
lars@metafoo.de, pmeerw@pmeerw.net, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: adc: ina2xx: remove unused debug field from chip global data
Date: Sat, 3 Sep 2016 16:01:34 +0100 [thread overview]
Message-ID: <30c4903f-182c-e551-bf02-4c02ba109f66@kernel.org> (raw)
In-Reply-To: <20160903025410.GA19426@d830.WORKGROUP>
On 03/09/16 03:54, Alison Schofield wrote:
> commit 1961bce76452 "iio: ina2xx: Remove trace_printk debug
> statements" removed the code that used the chip->prev_ns field.
> This patch cleans it up further by removing the unused field
> and assignments.
>
> Signed-off-by: Alison Schofield <amsfield22@gmail.com>
> Cc: Daniel Baluta <daniel.baluta@gmail.com>
Applied to the togreg branch of iio.git.
As ever pushed out as testing first for the auto builders to
play with it.
Thanks,
Jonathan
> ---
> drivers/iio/adc/ina2xx-adc.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/iio/adc/ina2xx-adc.c b/drivers/iio/adc/ina2xx-adc.c
> index 955f3fd..59b7d76 100644
> --- a/drivers/iio/adc/ina2xx-adc.c
> +++ b/drivers/iio/adc/ina2xx-adc.c
> @@ -114,7 +114,6 @@ struct ina2xx_chip_info {
> struct mutex state_lock;
> unsigned int shunt_resistor;
> int avg;
> - s64 prev_ns; /* track buffer capture time, check for underruns */
> int int_time_vbus; /* Bus voltage integration time uS */
> int int_time_vshunt; /* Shunt voltage integration time uS */
> bool allow_async_readout;
> @@ -509,8 +508,6 @@ static int ina2xx_work_buffer(struct iio_dev *indio_dev)
> iio_push_to_buffers_with_timestamp(indio_dev,
> (unsigned int *)data, time_a);
>
> - chip->prev_ns = time_a;
> -
> return (unsigned long)(time_b - time_a) / 1000;
> };
>
> @@ -554,8 +551,6 @@ static int ina2xx_buffer_enable(struct iio_dev *indio_dev)
> dev_dbg(&indio_dev->dev, "Async readout mode: %d\n",
> chip->allow_async_readout);
>
> - chip->prev_ns = iio_get_time_ns(indio_dev);
> -
> chip->task = kthread_run(ina2xx_capture_thread, (void *)indio_dev,
> "%s:%d-%uus", indio_dev->name, indio_dev->id,
> sampling_us);
>
prev parent reply other threads:[~2016-09-03 15:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-03 2:54 [PATCH] iio: adc: ina2xx: remove unused debug field from chip global data Alison Schofield
2016-09-03 15:01 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=30c4903f-182c-e551-bf02-4c02ba109f66@kernel.org \
--to=jic23@kernel.org \
--cc=afd@ti.com \
--cc=amsfield22@gmail.com \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mtitinger@baylibre.com \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).