From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E149AC433E0 for ; Fri, 3 Jul 2020 07:48:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C85D221897 for ; Fri, 3 Jul 2020 07:48:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726367AbgGCHsy (ORCPT ); Fri, 3 Jul 2020 03:48:54 -0400 Received: from gloria.sntech.de ([185.11.138.130]:38340 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725960AbgGCHsy (ORCPT ); Fri, 3 Jul 2020 03:48:54 -0400 Received: from p5b127e6f.dip0.t-ipconnect.de ([91.18.126.111] helo=phil.localnet) by gloria.sntech.de with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jrGR9-0003AF-4z; Fri, 03 Jul 2020 09:48:43 +0200 From: Heiko Stuebner To: Jonathan Cameron Cc: knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, xxm@rock-chips.com Subject: Re: [PATCH v6 1/3] iio: adc: rockchip_saradc: move all of probe to devm-functions Date: Fri, 03 Jul 2020 09:48:42 +0200 Message-ID: <3183602.Ou33jPcMzM@phil> In-Reply-To: <20200627130329.66d7102f@archlinux> References: <20200623233011.2319035-1-heiko@sntech.de> <20200627130329.66d7102f@archlinux> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org Am Samstag, 27. Juni 2020, 14:03:29 CEST schrieb Jonathan Cameron: > On Wed, 24 Jun 2020 01:30:09 +0200 > Heiko Stuebner wrote: > > > From: Heiko Stuebner > > > > Parts of the saradc probe rely on devm functions and later parts do not. > > This makes it more difficult to for example enable triggers via their > > devm-functions and would need more undo-work in remove. > > > > So to make life easier for the driver, move the rest of probe calls > > also to their devm-equivalents. > > > > This includes moving the clk- and regulator-disabling to a devm_action > > so that they gets disabled both during remove and in the error case > > in probe, after the action is registered. > > > > Signed-off-by: Heiko Stuebner > Looks good to me. Applied to the togreg branch of iio.git with one small > tweak. See inline. > > One other thing whilst we are here. Why do we need the build dependence > on ARM? I guess originally it was there simply, because Rockchip only makes ARM-SoCs so as not to pollute the config with too many unusable options and it had the COMPILE_TEST for the test-builds. But if one driver more doesn't really matter, it can of course also just go away. > I just scrapped it and the driver builds fine on x86 so would > be good to get the additional build coverage if we can. So I guess you'd like a patch removing that part, right? Because I guess the "I just scrapped it" meant locally, as I can't find a commit of that sort in the testing branch ;-) Heiko > > --- > > changes in v6: > > - move devm actions into separate functions as suggested by Jonathan > > changes in v5: > > - none > > changes in v4: > > - new patch as suggested by Jonathan > > > > drivers/iio/adc/rockchip_saradc.c | 72 ++++++++++++++++++++----------- > > 1 file changed, 46 insertions(+), 26 deletions(-) > > > > diff --git a/drivers/iio/adc/rockchip_saradc.c b/drivers/iio/adc/rockchip_saradc.c > > index 582ba047c4a6..1a7990d60f9f 100644 > > --- a/drivers/iio/adc/rockchip_saradc.c > > +++ b/drivers/iio/adc/rockchip_saradc.c > > @@ -193,6 +193,27 @@ static void rockchip_saradc_reset_controller(struct reset_control *reset) > > reset_control_deassert(reset); > > } > > > > +static void rockchip_saradc_clk_disable(void *data) > > +{ > > + struct rockchip_saradc *info = data; > > + > > + clk_disable_unprepare(info->clk); > > +} > > + > > +static void rockchip_saradc_pclk_disable(void *data) > > +{ > > + struct rockchip_saradc *info = data; > > + > > + clk_disable_unprepare(info->pclk); > > +} > > + > > +static void rockchip_saradc_regulator_disable(void *data) > > +{ > > + struct rockchip_saradc *info = data; > > + > > + regulator_disable(info->vref); > > +} > > + > > static int rockchip_saradc_probe(struct platform_device *pdev) > > { > > struct rockchip_saradc *info = NULL; > > @@ -291,17 +312,38 @@ static int rockchip_saradc_probe(struct platform_device *pdev) > > dev_err(&pdev->dev, "failed to enable vref regulator\n"); > > return ret; > > } > > + ret = devm_add_action_or_reset(&pdev->dev, > > + rockchip_saradc_regulator_disable, info); > > + if (ret) { > > + dev_err(&pdev->dev, "failed to register devm action, %d\n", > > + ret); > > + return ret; > > + } > > > > ret = clk_prepare_enable(info->pclk); > > if (ret < 0) { > > dev_err(&pdev->dev, "failed to enable pclk\n"); > > - goto err_reg_voltage; > > + return ret; > > + } > > + ret = devm_add_action_or_reset(&pdev->dev, > > + rockchip_saradc_pclk_disable, info); > > + if (ret) { > > + dev_err(&pdev->dev, "failed to register devm action, %d\n", > > + ret); > > + return ret; > > } > > > > ret = clk_prepare_enable(info->clk); > > if (ret < 0) { > > dev_err(&pdev->dev, "failed to enable converter clock\n"); > > - goto err_pclk; > > + return ret; > > + } > > + ret = devm_add_action_or_reset(&pdev->dev, > > + rockchip_saradc_clk_disable, info); > > + if (ret) { > > + dev_err(&pdev->dev, "failed to register devm action, %d\n", > > + ret); > > + return ret; > > } > > > > platform_set_drvdata(pdev, indio_dev); > > @@ -315,30 +357,9 @@ static int rockchip_saradc_probe(struct platform_device *pdev) > > indio_dev->channels = info->data->channels; > > indio_dev->num_channels = info->data->num_channels; > > > > - ret = iio_device_register(indio_dev); > > + ret = devm_iio_device_register(&pdev->dev, indio_dev); > > if (ret) > > - goto err_clk; > > - > > - return 0; > > - > > -err_clk: > > - clk_disable_unprepare(info->clk); > > -err_pclk: > > - clk_disable_unprepare(info->pclk); > > -err_reg_voltage: > > - regulator_disable(info->vref); > > - return ret; > > -} > > - > > -static int rockchip_saradc_remove(struct platform_device *pdev) > > -{ > > - struct iio_dev *indio_dev = platform_get_drvdata(pdev); > > - struct rockchip_saradc *info = iio_priv(indio_dev); > > - > > - iio_device_unregister(indio_dev); > > - clk_disable_unprepare(info->clk); > > - clk_disable_unprepare(info->pclk); > > - regulator_disable(info->vref); > > + return ret; > Small tweak rather hidden by how diff presents this but > might as well just > > return devm_iio_device_register > > > > > return 0; > > } > > @@ -383,7 +404,6 @@ static SIMPLE_DEV_PM_OPS(rockchip_saradc_pm_ops, > > > > static struct platform_driver rockchip_saradc_driver = { > > .probe = rockchip_saradc_probe, > > - .remove = rockchip_saradc_remove, > > .driver = { > > .name = "rockchip-saradc", > > .of_match_table = rockchip_saradc_match, > >