From: Stefan Wahren <stefan.wahren@i2se.com>
To: Ksenija Stanojevic <ksenija.stanojevic@gmail.com>
Cc: linux-input@vger.kernel.org, Lee Jones <lee.jones@linaro.org>,
pmeerw@pmeerw.net, jic23@kernel.org,
linux-kernel@vger.kernel.org,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
knaack.h@gmx.de, lars@metafoo.de, harald@ccbib.org,
fabio.estevam@freescale.com, linux-iio@vger.kernel.org,
marex@denx.de
Subject: Re: [PATCH v14 1/5] mfd: mxs-lradc: Add support for mxs-lradc MFD
Date: Wed, 15 Mar 2017 22:10:45 +0100 (CET) [thread overview]
Message-ID: <365485304.502411.1489612245583@email.1und1.de> (raw)
In-Reply-To: <20170314110545.54jz53xx36vsc3bo@dell>
Hi Ksenija,
> Lee Jones <lee.jones@linaro.org> hat am 14. März 2017 um 12:05 geschrieben:
>
>
> On Wed, 01 Mar 2017, Dmitry Torokhov wrote:
>
> > On Wed, Mar 01, 2017 at 09:10:50PM +0100, Stefan Wahren wrote:
...
> > >
> > > Since touchscreen is optional it doesn't make to try to register it, notice in the touchscreen driver there is no touchscreen, give the user a confusing error and finally disable the clock.
> > >
> > > Here are my suggestions:
> > >
> > > 1) Use the solution from Patch V6 but with an explaining comment that touchscreen is optional
> > >
> > > if (!lradc->touchscreen_wire)
> > > return 0;
> > >
> > > 2) Return a special error from touchscreen registration so mfd knowns this result is expected.
> > >
> > > I'm open for better solutions.
> > >
> > > @Lee: What's your opinion?
> >
> > I am not Lee, but given that this module already parses touchscreen
> > properties and knows whether there is touchscreen or not, #1 seems
> > simple and logical.
>
> Sorry for the delay, I'm currently behind on my mail due to vacation
> and conferences.
>
> +1
>
could you please submit a V15? It would be great to get this into 4.12.
Thanks
Stefan
next prev parent reply other threads:[~2017-03-15 21:18 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-01 18:02 [PATCH v14 0/5] mxs-lradc: Split driver into MFD Ksenija Stanojevic
2017-03-01 18:02 ` [PATCH v14 1/5] mfd: mxs-lradc: Add support for mxs-lradc MFD Ksenija Stanojevic
2017-03-01 20:10 ` Stefan Wahren
2017-03-01 20:48 ` Dmitry Torokhov
2017-03-14 11:05 ` Lee Jones
2017-03-15 21:10 ` Stefan Wahren [this message]
2017-03-01 18:02 ` [PATCH v14 2/5] iio: adc: mxs-lradc: Add support for adc driver Ksenija Stanojevic
2017-03-01 18:02 ` [PATCH v14 3/5] input: touchscreen: mxs-lradc: Add support for touchscreen Ksenija Stanojevic
2017-03-01 20:52 ` Dmitry Torokhov
2017-03-01 23:25 ` Harald Geyer
2017-03-02 19:55 ` Jonathan Cameron
2017-03-01 18:02 ` [PATCH v14 4/5] iio: adc: mxs-lradc: Remove driver Ksenija Stanojevic
2017-03-01 18:02 ` [PATCH v14 5/5] mfd: Move binding document Ksenija Stanojevic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=365485304.502411.1489612245583@email.1und1.de \
--to=stefan.wahren@i2se.com \
--cc=dmitry.torokhov@gmail.com \
--cc=fabio.estevam@freescale.com \
--cc=harald@ccbib.org \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=ksenija.stanojevic@gmail.com \
--cc=lars@metafoo.de \
--cc=lee.jones@linaro.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marex@denx.de \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox