From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D49BA322B62 for ; Mon, 15 Dec 2025 17:50:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765821050; cv=none; b=dPuCtL9pQcP3uzC+qr04CewxRLetqwOxjQ5JZ3y89Vdn+PQMLFVczOgMOYE+wRR+WnlA4Aeuz64ml7eqFPNMEitt2DDWszkpcLNvhwGhvl6w98P8Fd+JqJKnbJW/xFwgrw8WAfSvHeJqI+yChK9kBpE/AR4+L+SJJCXkM9DDbGg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765821050; c=relaxed/simple; bh=wKhD1Qe/u0NUDdPbkZCfx21AlyFOuwnlV2jBRJnXtPU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=bBU2HV0rBcfyM48vYP8h94LZ6B4mNOZvvbbp53CUze6Ngflfol1c6cjBRBEXI1kEU2WBy6RwejVdjrifX1zsiX5WhdWxmAMSucSjXXMEk5C/+JoyXHr54uKCVH3Lne1okaPUNLAx3Hws0ONMxBJsPASUhRmgvEmR9f/9lx5zi/Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=hexUCcYB; arc=none smtp.client-ip=209.85.214.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="hexUCcYB" Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-2a09a3bd9c5so18205435ad.3 for ; Mon, 15 Dec 2025 09:50:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1765821048; x=1766425848; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=SizWLQ4gEz9gKPbNGWru/XLkTBLjWoFV840U2e1HA8M=; b=hexUCcYB1TE+HATDnbKeTaDuKuvvBXq/paWnXZrXovf4zuzbsfCfMWxawT82ca7rqL KnOwvLIk17liUzLdarKhjl8FKHjk5uW+aL+PMCJnw8bNb61k6Bf4900Q3I5ee0fsQGri rNL7CuYy8mDC8RmIeCQ8RqSbz5vNCh+gURzBUZVpNZYqm5Ww57lW6ix2tm87R+EHg6bh WM0ULBe0LDVK+207ObCgetTQ/przfnzxYp2kIMUUx9FhZVfM3B0+0NO4XJ/XUJyqwQfM XgAI06UFtv8wrkB/4o+d3dgAQuDz9NeOFmdM+9gwS6X0s/9AOXh+cImWQMBQWc3cYaJB PB7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765821048; x=1766425848; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=SizWLQ4gEz9gKPbNGWru/XLkTBLjWoFV840U2e1HA8M=; b=xNIOdDH4W5wclMy08nGxajlkql3sXDYos4C5KqdxjTmxwg5iwDbkqFY3GEmilxN2DE jgL5m4MzGNy6DmC4l0nC2uSJoQT5Nj7m31DXeFAkmAqHyOZYa85Ev4D6cfU3nw0Eomdm F3qQA3RFkDpPstsMXln/88tx5w1LuohQr3fRRm3aIyuY3BmZvkR1d84i3U6p3UItVevt QWWpEOrJjwwVeiGzrPPQMFolaIQOPqwou9OyAesDVhUU/ss1d2FlkgDxPlcvhxsXDIdI cqbbigyZqF1DY5pdflkvn4z4RYOmPmdw+f1/VBpC3kLQMZdFMGheqAl6tGEEM7Idqx6X MLnw== X-Forwarded-Encrypted: i=1; AJvYcCUsXJrltoUw6ZjfGogUNtoppdKJ7c5my/VDphjLSn/NVifDwfADhT8EeT8slAcCcoKcbk+IPve3AHg=@vger.kernel.org X-Gm-Message-State: AOJu0YwJNezW7HAf6qNCEC48+8GizZa1rbe3HYtcuqPGPr/kfTVi38nB 5WISc/k6wFvijhIoUJnAzYiW5U/xeVcxJ0Z57A5ai7/PF7Gpn9O+fiOJ X-Gm-Gg: AY/fxX64pMb8UroqgMl4X8Q0jrr7di947Fq4ICedW+rCcTtdBBdPJTnYbO8careBgh6 QxoIuw0OkmjzX6nRCOOdJ3jpAKfVnjmUbwyQw5v43ZWPkIAKffTNzHgUe+uXIb6rcZxj9F1dbn6 dPydzEVHRUyW3j4RwVkI/PubKRjp3uw0XFIDP0xc5J3Psm54RLkNIiYMzGsmu0uCuQHBY+mcf9E TdnoB//Py/NZMmfdUY7O9qEpsOq2nyeQSngWz3xD8N3UvPr4uOQxBzv9Z5xdCEovQsr4lHqHv4K KVVKenyH6jxs3XDCLPWAiTeRPG+MDzLm4mYVjESI571XXda0gu9zPnB8ubUM3dH+CaM7PGmJPns /mMcc0W6FReO4XcTWm4NIciXZP0R4VtW/vCMuirFTsTkpmAYaunJaPCpx0vHrLxvY6WmP1VYGtS jeRwpzfh9/nMR7VxclBWVjEj4PgPvZi6Vx+ZMzxuQKheDa1ZJbwqXsqi1NFgAnMyk= X-Google-Smtp-Source: AGHT+IEQ+4+TeVYmp/ChyVlFUe2X4ufWClEt78idDjNBALBIwJCrPDr379ZA25vJ6B1jLbIM6oZ2/Q== X-Received: by 2002:a17:903:fa6:b0:29f:13d2:1c5e with SMTP id d9443c01a7336-29f23e4696fmr129429535ad.21.1765821047933; Mon, 15 Dec 2025 09:50:47 -0800 (PST) Received: from ?IPV6:2402:e280:21d3:2:50bc:8636:2ee8:5158? ([2402:e280:21d3:2:50bc:8636:2ee8:5158]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a0e2318990sm43179675ad.38.2025.12.15.09.50.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 15 Dec 2025 09:50:47 -0800 (PST) Message-ID: <37d8b0fc-db25-4ce6-89e1-3cd4e447e005@gmail.com> Date: Mon, 15 Dec 2025 23:20:37 +0530 Precedence: bulk X-Mailing-List: linux-iio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/2] iio: adc: Add support for TI ADS1120 To: David Lechner , jic23@kernel.org Cc: nuno.sa@analog.com, andy@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20251109141119.561756-1-ajithanandhan0406@gmail.com> <20251109141119.561756-3-ajithanandhan0406@gmail.com> <5f15284b-159b-4860-b58b-35c624e2539f@baylibre.com> <8e2c73ca-3746-4b2a-9d85-c12b51a69059@gmail.com> <8ad18de5-53cd-49ba-8e84-1e8c7e5bd627@baylibre.com> <15106906-3bcc-4187-87d9-c838fe99b583@gmail.com> <5926ca19-c204-4abc-9e59-86a797b63b5c@baylibre.com> Content-Language: en-US From: Ajith Anandhan In-Reply-To: <5926ca19-c204-4abc-9e59-86a797b63b5c@baylibre.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit >> >> >> Thanks for the pointer. >> >> I did look at reg_shift, but it doesn’t fit this device. With .reg_shift = 2, regmap would send only (reg << 2) (e.g. 0x0c for reg 3). >> >> The ADS1120 requires the command byte to be CMD | (reg << 2) (e.g. 0x20 | 0x0c = 0x2c for an RREG of reg 3). >> >> Similarly, >> >>  .read_flag_mask would produce reg | mask (e.g. 0x03 | 0x20 = 0x23), which is also not the required format. >> >> Unless I’m missing a regmap configuration that can generate (reg << 2) | CMD as a single byte, >> >> a custom regmap bus seems necessary here. Please let me know if there is a way to express this with standard regmap-spi. >> >> >> > Sorry, I didn't read carefully enough. Wouldn't this work though? > > .reg_bits = 2, > .reg_shift = 2, > .read_flag_mask = 0x20, > .write_flag_mask = 0x40, > > > Then a read should be 0x20 | ((reg & 0x3) << 2) and a write should be 0x40 | ((reg & 0x3) << 2). Yes, that works thanks for spelling it out. I missed the reg_bits interaction earlier. I’ll drop the custom regmap bus and switch to standard regmap-spi.