From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oi1-f179.google.com (mail-oi1-f179.google.com [209.85.167.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 24FEB1FF1A7 for ; Thu, 20 Feb 2025 17:16:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740071811; cv=none; b=rvCF3nzB+xtJ5VeWXyI3iR/XmNKdyQjGu0xHfJStXJ+dULvy/LexwN9ToL2inPCkEdC1NkG2hLtPm7Nuc5FewjU85B6c75l3gzZ3RZmI6bP0S3yGZ6lOI2DqEZfr9JV4gwYs42PtVqNdo8WIxf+LnK0qgD6CDr03QH6hWHHuNeo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740071811; c=relaxed/simple; bh=244XeKEKX+5A8ehxHdeeLmwJwhJA1rgjh3BsIfR/8tM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=mVn80J7Z0QHDrtc6eGiwZjxK4DMKNfhxza9TOHTj9vCLM52qnYtCr7j9DtmVqIDfS17Xng19vFy4EuA9bxqbEzYhot4TLyJKLg+8/4R9G0dm++w8NuvPH89wPo8xwJTjvFMF/0mqJCuvxjWDllRpreSdAR+j0cwY0NuQpDzaj78= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=0dHwAlgy; arc=none smtp.client-ip=209.85.167.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="0dHwAlgy" Received: by mail-oi1-f179.google.com with SMTP id 5614622812f47-3f3fa5699a1so589421b6e.0 for ; Thu, 20 Feb 2025 09:16:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1740071808; x=1740676608; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=QcApaWVKSxQSIvLEEHhnSoFMNHumzt0nl4dOj28dnl0=; b=0dHwAlgykdXsqX1wYLYwXt2Ts6SA+KR2AVFl1WMrJgrYcqwb03g2FGq+gIlg79FlGl HxGhNcYVONWq8D+2KmxIXUuurbEKtF5vSXt6rNUzHDenwAPnne5yVzPmYKFhRUestJUt lnTuxe3XS4a+qI4UZdD/MqPZ/iSKemhkEga8k3sBjRsqEnrXSginVeTCQyBWYKjIrR1w 9m01GH1SD5LP5gObtGkv2JLIRP8g7Rttsrfda6eFuGk8j720J9T5rKunXb0SrEsRTrB5 PrpiTOkYk14eJuJrhMuJlOrg/UI8dDwO3e6bepwWbwqQZ92UqXDPipJ2wzSQTSeT1onq 5YJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740071808; x=1740676608; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=QcApaWVKSxQSIvLEEHhnSoFMNHumzt0nl4dOj28dnl0=; b=deKIpVbUJQspAdiZQM/BkT4/p30CiIAUljOsjgZJ4iwVXJy0AMVIIDgkkNWE5MBB3T ZUTch4Xel4ztpkGD4utCRpDWHGj8vVD2LQaoIQ9ov6QfO3JJnyfnWdnZUUU9iYbvw/X9 OrYkgSfcvbo7xxjye0SJ0gHe+bhd9XWBrIL4V0xZz0S2tCGRbl0PCdmrm8spFCEJmtCg ALOxIYdHCS0i3VWi5eKt8ZQvJojSWfEBt/gi3EgXCTwy2zHiY//NrkifL5Yo3Eno6oY2 18R719C3z4KIDEqfdKhPt+DXXF5AZE1aHpsj/NRwf31tWW4RPOpwxKVJyu4nmrIk3KhH EvRA== X-Forwarded-Encrypted: i=1; AJvYcCUbPNriICGqmb8e5jS75+1scOsLNVPiem9c9HXOkG6jI8+fCarm9PPU6zfp5r2gR/ZsJLB71dt35LU=@vger.kernel.org X-Gm-Message-State: AOJu0YwecuXpCgVrgtp4Bnwmw83ujkWCTb4Dm0adolZaBBsN+GyP6rMm Molk8rO1pB3jxjUX4fKjC9RFhfFhxoenHuFZOzKpaDuYICjssTlBOHRj6h/AHdY= X-Gm-Gg: ASbGncun0zVunIwjMStPJnGkREENenDFHlwNp4TpXZG2qPGJeVB1qSYjBiIHlyfDzcM pqfNzGhU7kNyLzkm3XMiu6yuYbo2m0iFCUMYmHC0mNXY+hY9Z7R+2oH1hecnI9+0TgecQtM/sNk QFYIm0Gpqkaaw0868hCOI5/0rph5U2UNR+3TdQpOkHL/1McS3j536/y5QFR/ePVur6SgHxIRzgK cynt8KUezVmSGVaez2jPktkfLLlk6a4H4ZPBNit5rNC2VHkKdw6DX7W+HJN1Og57Y3gpL3lGuoM R8gtNCwYwQp7tCdV3CqP1J2tf5Dop51bY4N09hJhXtUISUkAtjp/ X-Google-Smtp-Source: AGHT+IFQ4fpht1GK2L64Lff/K3FzPWt1QsXeXeofzfatOKhBNQXj463x1jUtS3u3WnZ5Fb1+N2LaOQ== X-Received: by 2002:a05:6808:3996:b0:3f4:205c:d9aa with SMTP id 5614622812f47-3f424701c1dmr163494b6e.21.1740071808115; Thu, 20 Feb 2025 09:16:48 -0800 (PST) Received: from [192.168.0.142] (ip98-183-112-25.ok.ok.cox.net. [98.183.112.25]) by smtp.gmail.com with ESMTPSA id 5614622812f47-3f3da962049sm5144033b6e.21.2025.02.20.09.16.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 20 Feb 2025 09:16:46 -0800 (PST) Message-ID: <37dc5907-b04f-4879-8271-68e36a6a2924@baylibre.com> Date: Thu, 20 Feb 2025 11:16:44 -0600 Precedence: bulk X-Mailing-List: linux-iio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 05/15] bus: ts-nbus: use bitmap_get_value8() To: Andy Shevchenko , Simon Horman Cc: Linus Walleij , Bartosz Golaszewski , Andy Shevchenko , Geert Uytterhoeven , Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Ulf Hansson , Peter Rosin , Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Vinod Koul , Kishon Vijay Abraham I , =?UTF-8?Q?Nuno_S=C3=A1?= , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-mmc@vger.kernel.org, netdev@vger.kernel.org, linux-phy@lists.infradead.org, linux-sound@vger.kernel.org References: <20250210-gpio-set-array-helper-v3-0-d6a673674da8@baylibre.com> <20250210-gpio-set-array-helper-v3-5-d6a673674da8@baylibre.com> <20250220101742.GR1615191@kernel.org> Content-Language: en-US From: David Lechner In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 2/20/25 6:06 AM, Andy Shevchenko wrote: > On Thu, Feb 20, 2025 at 12:17 PM Simon Horman wrote: >> On Mon, Feb 10, 2025 at 04:33:31PM -0600, David Lechner wrote: > > ... > >> But when compiling with GCC 14.2.0 I see warnings that values >> is used uninitialised - bitmap_set_value8() appears to rely on >> it being so. > >> In file included from drivers/bus/ts-nbus.c:13: >> In function ‘bitmap_write’, >> inlined from ‘ts_nbus_reset_bus’ at drivers/bus/ts-nbus.c:111:2: >> ./include/linux/bitmap.h:818:12: error: ‘values’ is used uninitialized [-Werror=uninitialized] >> 818 | map[index] &= (fit ? (~(mask << offset)) : ~BITMAP_FIRST_WORD_MASK(start)); >> | ~~~^~~~~~~ > > Heh, the compiler is dumb. Even if it's not initialised we do not care. > > ... > > Wondering if the bitmap_write() will work better... > It is already using that: #define bitmap_set_value8(map, value, start) \ bitmap_write(map, value, start, BITS_PER_BYTE)