linux-iio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Matt Ranostay <mranostay@gmail.com>, Wei Yongjun <weiyj.lk@gmail.com>
Cc: Hartmut Knaack <knaack.h@gmx.de>,
	Lars-Peter Clausen <lars@metafoo.de>,
	Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
	Wei Yongjun <weiyongjun1@huawei.com>,
	linux-iio@vger.kernel.org
Subject: Re: [PATCH -next] iio: temperature: fix non static symbol warnings
Date: Mon, 29 Aug 2016 19:49:43 +0100	[thread overview]
Message-ID: <396702fd-dbd0-a9dc-ec23-c59b8dd1a68a@kernel.org> (raw)
In-Reply-To: <F9B1372A-28A3-4B3B-98CA-09BDA439A97D@gmail.com>

On 27/08/16 09:51, Matt Ranostay wrote:
> Reviewed-By: Matt Ranostay <mranostay@gmail.com>
Applied to the togreg branch of iio.git.
This will be initially pushed out as testing for the autobuilders
to play with it.

Thanks,

Jonathan
> 
>> On Aug 26, 2016, at 07:33, Wei Yongjun <weiyj.lk@gmail.com> wrote:
>>
>> From: Wei Yongjun <weiyongjun1@huawei.com>
>>
>> Fixes the following sparse warnings:
>>
>> drivers/iio/temperature/maxim_thermocouple.c:35:28: warning:
>> symbol 'max6675_channels' was not declared. Should it be static?
>> drivers/iio/temperature/maxim_thermocouple.c:52:28: warning:
>> symbol 'max31855_channels' was not declared. Should it be static?
>> drivers/iio/temperature/maxim_thermocouple.c:98:38: warning:
>> symbol 'maxim_thermocouple_chips' was not declared. Should it be static?
>>
>> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
>> ---
>> drivers/iio/temperature/maxim_thermocouple.c | 6 +++---
>> 1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/iio/temperature/maxim_thermocouple.c b/drivers/iio/temperature/maxim_thermocouple.c
>> index 030827e..39dd202 100644
>> --- a/drivers/iio/temperature/maxim_thermocouple.c
>> +++ b/drivers/iio/temperature/maxim_thermocouple.c
>> @@ -32,7 +32,7 @@ enum {
>>    MAX31855,
>> };
>>
>> -const struct iio_chan_spec max6675_channels[] = {
>> +static const struct iio_chan_spec max6675_channels[] = {
>>    {    /* thermocouple temperature */
>>        .type = IIO_TEMP,
>>        .info_mask_separate =
>> @@ -49,7 +49,7 @@ const struct iio_chan_spec max6675_channels[] = {
>>    IIO_CHAN_SOFT_TIMESTAMP(1),
>> };
>>
>> -const struct iio_chan_spec max31855_channels[] = {
>> +static const struct iio_chan_spec max31855_channels[] = {
>>    {    /* thermocouple temperature */
>>        .type = IIO_TEMP,
>>        .address = 2,
>> @@ -95,7 +95,7 @@ struct maxim_thermocouple_chip {
>>    u32 status_bit;
>> };
>>
>> -const struct maxim_thermocouple_chip maxim_thermocouple_chips[] = {
>> +static const struct maxim_thermocouple_chip maxim_thermocouple_chips[] = {
>>    [MAX6675] = {
>>            .channels = max6675_channels,
>>            .num_channels = ARRAY_SIZE(max6675_channels),
>>
>>
>>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 


      reply	other threads:[~2016-08-29 18:49 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-26 14:33 [PATCH -next] iio: temperature: fix non static symbol warnings Wei Yongjun
2016-08-27  8:51 ` Matt Ranostay
2016-08-29 18:49   ` Jonathan Cameron [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=396702fd-dbd0-a9dc-ec23-c59b8dd1a68a@kernel.org \
    --to=jic23@kernel.org \
    --cc=knaack.h@gmx.de \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=mranostay@gmail.com \
    --cc=pmeerw@pmeerw.net \
    --cc=weiyj.lk@gmail.com \
    --cc=weiyongjun1@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).