From: Erikas Bitovtas <xerikasxx@gmail.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: "Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Peter Meerwald" <pmeerw@pmeerw.net>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
~postmarketos/upstreaming@lists.sr.ht,
phone-devel@vger.kernel.org
Subject: Re: [PATCH v4 1/2] dt-bindings: iio: light: vcnl4000: add Capella CM36686 and CM36672P
Date: Fri, 13 Feb 2026 10:29:02 +0200 [thread overview]
Message-ID: <3a20c906-647c-458f-a118-c7927495e7ef@gmail.com> (raw)
In-Reply-To: <20260213-unyielding-pistachio-ape-deda74@quoll>
On 2/13/26 9:54 AM, Krzysztof Kozlowski wrote:
> On Thu, Feb 12, 2026 at 04:42:47PM +0200, Erikas Bitovtas wrote:
>> Capella CM36686 is an ambient light and proximity sensor developed by
>> Capella Microsystems, now a subsidiary of Vishay Intertechnology Inc. It
>> has an I2C address of 0x60 and is fully compatible with an existing
>> driver for VCNL4040.
>
> I wonder why and how...
VCNL4040 shares the same digital interface as CM36686. All the registers
and their fields are the same. It is most likely Vishay just reused the
CM36686 design for VCNL4040.
>
>> Capella CM36672P is a proximity-only sensor that
>> is fully compatible with CM36686, and therefore with VCNL4040. Add
>> compatibles for cm36672p and cm36686, with a fallback for cm36686 of
>> vcnl4040.
>>
>> Signed-off-by: Erikas Bitovtas <xerikasxx@gmail.com>
>> ---
>> .../devicetree/bindings/iio/light/vishay,vcnl4000.yaml | 17 +++++++++++------
>> 1 file changed, 11 insertions(+), 6 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/iio/light/vishay,vcnl4000.yaml b/Documentation/devicetree/bindings/iio/light/vishay,vcnl4000.yaml
>> index 4d1a225e8868..2ba4d5de4ec4 100644
>> --- a/Documentation/devicetree/bindings/iio/light/vishay,vcnl4000.yaml
>> +++ b/Documentation/devicetree/bindings/iio/light/vishay,vcnl4000.yaml
>> @@ -18,12 +18,17 @@ allOf:
>>
>> properties:
>> compatible:
>> - enum:
>> - - vishay,vcnl4000
>> - - vishay,vcnl4010
>> - - vishay,vcnl4020
>> - - vishay,vcnl4040
>> - - vishay,vcnl4200
>> + oneOf:
>> + - enum:
>> + - capella,cm36672p
>
> CM36672P is compatible with CM36686, but this is not expressed.
> Confusing commit msg and code.
For CM36672P we create a dedicated compatible because it is a
proximity-only sensor which has the same proximity sensor configuration,
but ambient light sensor registers are missing (reserved).
>> + - vishay,vcnl4000
>> + - vishay,vcnl4010
>> + - vishay,vcnl4020
>> + - vishay,vcnl4040
>
> Best regards,
> Krzysztof
>
next prev parent reply other threads:[~2026-02-13 8:29 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-12 14:42 [PATCH v4 0/2] iio: light: Add support for Capella cm36686 and cm36672p sensors Erikas Bitovtas
2026-02-12 14:42 ` [PATCH v4 1/2] dt-bindings: iio: light: vcnl4000: add Capella CM36686 and CM36672P Erikas Bitovtas
2026-02-13 7:54 ` Krzysztof Kozlowski
2026-02-13 8:29 ` Erikas Bitovtas [this message]
2026-02-13 8:51 ` Krzysztof Kozlowski
2026-02-13 8:56 ` Erikas Bitovtas
2026-02-14 16:44 ` David Lechner
2026-02-15 16:16 ` Erikas Bitovtas
2026-02-15 19:35 ` Jonathan Cameron
2026-02-16 7:27 ` Krzysztof Kozlowski
2026-02-16 8:49 ` Erikas Bitovtas
2026-02-16 9:03 ` Krzysztof Kozlowski
2026-02-15 17:49 ` Jonathan Cameron
2026-02-15 18:00 ` Erikas Bitovtas
2026-02-15 19:38 ` Jonathan Cameron
2026-02-12 14:42 ` [PATCH v4 2/2] iio: light: vcnl4000: add support for " Erikas Bitovtas
2026-02-12 16:20 ` Andy Shevchenko
2026-02-14 18:09 ` Jonathan Cameron
2026-02-15 17:28 ` Erikas Bitovtas
2026-02-15 19:31 ` Jonathan Cameron
2026-02-15 20:06 ` Erikas Bitovtas
2026-02-15 21:55 ` Jonathan Cameron
2026-02-16 8:21 ` Erikas Bitovtas
2026-02-18 19:32 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3a20c906-647c-458f-a118-c7927495e7ef@gmail.com \
--to=xerikasxx@gmail.com \
--cc=andy@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=phone-devel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
--cc=robh@kernel.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox