linux-iio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Bhumika Goyal <bhumirks@gmail.com>,
	julia.lawall@lip6.fr, knaack.h@gmx.de, lars@metafoo.de,
	pmeerw@pmeerw.net, linux-iio@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: adc: constify iio_info structures
Date: Sun, 22 Jan 2017 13:19:31 +0000	[thread overview]
Message-ID: <3eb33e08-61d3-131c-4807-103fcee653ac@kernel.org> (raw)
In-Reply-To: <1485018180-22799-1-git-send-email-bhumirks@gmail.com>

On 21/01/17 17:03, Bhumika Goyal wrote:
> Declare iio_info structures as const as they are only stored in
> the info field of a iio_dev structure. This field is of type const,
> so iio_info structures having similar properties can be made const too.
> 
> File size before:
>    text	   data	    bss	    dec	    hex	filename
>    6944	    792	      0	   7736	   1e38	drivers/iio/adc/ti-ads1015.o
> 
> File size after:
>    text   data	    bss	    dec	    hex	filename
>    7264	    472	      0	   7736	   1e38	drivers/iio/adc/ti-ads1015.o
> 
> Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
Good find.

Applied to the togreg branch of iio.git and pushed out as testing
for the autobuilders to play with it.

Thanks,

Jonathan
> ---
>  drivers/iio/adc/ti-ads1015.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/iio/adc/ti-ads1015.c b/drivers/iio/adc/ti-ads1015.c
> index cde6f13..422b314 100644
> --- a/drivers/iio/adc/ti-ads1015.c
> +++ b/drivers/iio/adc/ti-ads1015.c
> @@ -472,14 +472,14 @@ static const struct attribute_group ads1115_attribute_group = {
>  	.attrs = ads1115_attributes,
>  };
>  
> -static struct iio_info ads1015_info = {
> +static const struct iio_info ads1015_info = {
>  	.driver_module	= THIS_MODULE,
>  	.read_raw	= ads1015_read_raw,
>  	.write_raw	= ads1015_write_raw,
>  	.attrs          = &ads1015_attribute_group,
>  };
>  
> -static struct iio_info ads1115_info = {
> +static const struct iio_info ads1115_info = {
>  	.driver_module	= THIS_MODULE,
>  	.read_raw	= ads1015_read_raw,
>  	.write_raw	= ads1015_write_raw,
> 


      reply	other threads:[~2017-01-22 13:19 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-21 17:03 [PATCH] iio: adc: constify iio_info structures Bhumika Goyal
2017-01-22 13:19 ` Jonathan Cameron [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3eb33e08-61d3-131c-4807-103fcee653ac@kernel.org \
    --to=jic23@kernel.org \
    --cc=bhumirks@gmail.com \
    --cc=julia.lawall@lip6.fr \
    --cc=knaack.h@gmx.de \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pmeerw@pmeerw.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).