[PATCH] iio: hid-sensor-als: Add realtime data type parse support

[PATCH] iio: hid-sensor-als: Add realtime data type parse support

[Song Hongyan]

In parse report function it only support to parse absolute data type
reported. Some platforms which report realtime data cannot be parsed,
they will get "Invalid Argument" when try to get sensor data.

Add realtime data type support to match different platforms.

Signed-off-by: Song Hongyan <hongyan.song@intel.com>
---
 drivers/iio/light/hid-sensor-als.c | 11 +++++++++++
 include/linux/hid-sensor-ids.h     |  1 +
 2 files changed, 12 insertions(+)

diff --git a/drivers/iio/light/hid-sensor-als.c b/drivers/iio/light/hid-sensor-als.c
index 8bb1f90..3b3aa66 100644
--- a/drivers/iio/light/hid-sensor-als.c
+++ b/drivers/iio/light/hid-sensor-als.c
@@ -252,6 +252,17 @@ static int als_parse_report(struct platform_device *pdev,
 			st->common_attributes.sensitivity.index,
 			st->common_attributes.sensitivity.report_id);
 	}
+	if (st->common_attributes.sensitivity.index < 0) {
+		sensor_hub_input_get_attribute_info(hsdev,
+			HID_FEATURE_REPORT, usage_id,
+			HID_USAGE_SENSOR_DATA_MOD_CHANGE_SENSITIVITY_REL_PCT |
+			HID_USAGE_SENSOR_LIGHT_ILLUM,
+			&st->common_attributes.sensitivity);
+		dev_dbg(&pdev->dev, "Sensitivity index:report %d:%d\n",
+			st->common_attributes.sensitivity.index,
+			st->common_attributes.sensitivity.report_id);
+	}
+
 	return ret;
 }
 
diff --git a/include/linux/hid-sensor-ids.h b/include/linux/hid-sensor-ids.h
index f2ee90a..755f5e2 100644
--- a/include/linux/hid-sensor-ids.h
+++ b/include/linux/hid-sensor-ids.h
@@ -141,6 +141,7 @@
 /* Per data field properties */
 #define HID_USAGE_SENSOR_DATA_MOD_NONE					0x00
 #define HID_USAGE_SENSOR_DATA_MOD_CHANGE_SENSITIVITY_ABS		0x1000
+#define HID_USAGE_SENSOR_DATA_MOD_CHANGE_SENSITIVITY_REL_PCT		0xE000
 
 /* Power state enumerations */
 #define HID_USAGE_SENSOR_PROP_POWER_STATE_UNDEFINED_ENUM	0x200850
-- 
1.9.1

Re: [PATCH] iio: hid-sensor-als: Add realtime data type parse support

[Jonathan Cameron]

On 28/10/16 02:20, Song Hongyan wrote:
> In parse report function it only support to parse absolute data type
> reported. Some platforms which report realtime data cannot be parsed,
> they will get "Invalid Argument" when try to get sensor data.
> 
> Add realtime data type support to match different platforms.
I'm not 100% sure that rel stands for real time here...

Relative percent?  There is also a percent of range option though no
idea if any hardware actually uses that.

Srinivas, could you take a look at this one as well.

thanks,

Jonathan
> 
> Signed-off-by: Song Hongyan <hongyan.song@intel.com>
> ---
>  drivers/iio/light/hid-sensor-als.c | 11 +++++++++++
>  include/linux/hid-sensor-ids.h     |  1 +
>  2 files changed, 12 insertions(+)
> 
> diff --git a/drivers/iio/light/hid-sensor-als.c b/drivers/iio/light/hid-sensor-als.c
> index 8bb1f90..3b3aa66 100644
> --- a/drivers/iio/light/hid-sensor-als.c
> +++ b/drivers/iio/light/hid-sensor-als.c
> @@ -252,6 +252,17 @@ static int als_parse_report(struct platform_device *pdev,
>  			st->common_attributes.sensitivity.index,
>  			st->common_attributes.sensitivity.report_id);
>  	}
> +	if (st->common_attributes.sensitivity.index < 0) {
> +		sensor_hub_input_get_attribute_info(hsdev,
> +			HID_FEATURE_REPORT, usage_id,
> +			HID_USAGE_SENSOR_DATA_MOD_CHANGE_SENSITIVITY_REL_PCT |
> +			HID_USAGE_SENSOR_LIGHT_ILLUM,
> +			&st->common_attributes.sensitivity);
> +		dev_dbg(&pdev->dev, "Sensitivity index:report %d:%d\n",
> +			st->common_attributes.sensitivity.index,
> +			st->common_attributes.sensitivity.report_id);
> +	}
> +
>  	return ret;
>  }
>  
> diff --git a/include/linux/hid-sensor-ids.h b/include/linux/hid-sensor-ids.h
> index f2ee90a..755f5e2 100644
> --- a/include/linux/hid-sensor-ids.h
> +++ b/include/linux/hid-sensor-ids.h
> @@ -141,6 +141,7 @@
>  /* Per data field properties */
>  #define HID_USAGE_SENSOR_DATA_MOD_NONE					0x00
>  #define HID_USAGE_SENSOR_DATA_MOD_CHANGE_SENSITIVITY_ABS		0x1000
> +#define HID_USAGE_SENSOR_DATA_MOD_CHANGE_SENSITIVITY_REL_PCT		0xE000
>  
>  /* Power state enumerations */
>  #define HID_USAGE_SENSOR_PROP_POWER_STATE_UNDEFINED_ENUM	0x200850
> 

Re: [PATCH] iio: hid-sensor-als: Add realtime data type parse support

[Pandruvada, Srinivas]

T24gU3VuLCAyMDE2LTEwLTMwIGF0IDE2OjI2ICswMDAwLCBKb25hdGhhbiBDYW1lcm9uIHdyb3Rl
Og0KPiBPbiAyOC8xMC8xNiAwMjoyMCwgU29uZyBIb25neWFuIHdyb3RlOg0KPiA+IA0KPiA+IElu
IHBhcnNlIHJlcG9ydCBmdW5jdGlvbiBpdCBvbmx5IHN1cHBvcnQgdG8gcGFyc2UgYWJzb2x1dGUg
ZGF0YQ0KPiA+IHR5cGUNCj4gPiByZXBvcnRlZC4gU29tZSBwbGF0Zm9ybXMgd2hpY2ggcmVwb3J0
IHJlYWx0aW1lIGRhdGEgY2Fubm90IGJlDQo+ID4gcGFyc2VkLA0KPiA+IHRoZXkgd2lsbCBnZXQg
IkludmFsaWQgQXJndW1lbnQiIHdoZW4gdHJ5IHRvIGdldCBzZW5zb3IgZGF0YS4NCj4gPiANCj4g
PiBBZGQgcmVhbHRpbWUgZGF0YSB0eXBlIHN1cHBvcnQgdG8gbWF0Y2ggZGlmZmVyZW50IHBsYXRm
b3Jtcy4NCj4gSSdtIG5vdCAxMDAlIHN1cmUgdGhhdCByZWwgc3RhbmRzIGZvciByZWFsIHRpbWUg
aGVyZS4uLg0KPiANCj4gUmVsYXRpdmUgcGVyY2VudD/CoMKgVGhlcmUgaXMgYWxzbyBhIHBlcmNl
bnQgb2YgcmFuZ2Ugb3B0aW9uIHRob3VnaCBubw0KPiBpZGVhIGlmIGFueSBoYXJkd2FyZSBhY3R1
YWxseSB1c2VzIHRoYXQuDQo+IA0KPiBTcmluaXZhcywgY291bGQgeW91IHRha2UgYSBsb29rIGF0
IHRoaXMgb25lIGFzIHdlbGwuDQpJIGFza2VkIEhvbmd5YW4gdG8gcG9zdCB0byBtYWlsaW5nIGxp
c3QgdG8gc2VlayBzb21lIG9waW5pb24uDQpUaGUgSUlPIEFCSSBoeXN0ZXJlc2lzIGlzIGFic29s
dXRlIHZhbHVlLCBidXQgdGhpcyB3aWxsIHNwZWNpZnkgYQ0KcmVsYXRpdmUgdmFsdWUgd2l0aCBw
ZXJjZW50YWdlLg0KSSB0aGluayB3ZSBuZWVkIGEgbmV3IEFCSS4NCg0KVGhhbmtzLA0KU3Jpbml2
YXMNCg0KDQo+IA0KPiB0aGFua3MsDQo+IA0KPiBKb25hdGhhbg0KPiA+IA0KPiA+IA0KPiA+IFNp
Z25lZC1vZmYtYnk6IFNvbmcgSG9uZ3lhbiA8aG9uZ3lhbi5zb25nQGludGVsLmNvbT4NCj4gPiAt
LS0NCj4gPiDCoGRyaXZlcnMvaWlvL2xpZ2h0L2hpZC1zZW5zb3ItYWxzLmMgfCAxMSArKysrKysr
KysrKw0KPiA+IMKgaW5jbHVkZS9saW51eC9oaWQtc2Vuc29yLWlkcy5owqDCoMKgwqDCoHzCoMKg
MSArDQo+ID4gwqAyIGZpbGVzIGNoYW5nZWQsIDEyIGluc2VydGlvbnMoKykNCj4gPiANCj4gPiBk
aWZmIC0tZ2l0IGEvZHJpdmVycy9paW8vbGlnaHQvaGlkLXNlbnNvci1hbHMuYw0KPiA+IGIvZHJp
dmVycy9paW8vbGlnaHQvaGlkLXNlbnNvci1hbHMuYw0KPiA+IGluZGV4IDhiYjFmOTAuLjNiM2Fh
NjYgMTAwNjQ0DQo+ID4gLS0tIGEvZHJpdmVycy9paW8vbGlnaHQvaGlkLXNlbnNvci1hbHMuYw0K
PiA+ICsrKyBiL2RyaXZlcnMvaWlvL2xpZ2h0L2hpZC1zZW5zb3ItYWxzLmMNCj4gPiBAQCAtMjUy
LDYgKzI1MiwxNyBAQCBzdGF0aWMgaW50IGFsc19wYXJzZV9yZXBvcnQoc3RydWN0DQo+ID4gcGxh
dGZvcm1fZGV2aWNlICpwZGV2LA0KPiA+IMKgCQkJc3QtPmNvbW1vbl9hdHRyaWJ1dGVzLnNlbnNp
dGl2aXR5LmluZGV4LA0KPiA+IMKgCQkJc3QtDQo+ID4gPmNvbW1vbl9hdHRyaWJ1dGVzLnNlbnNp
dGl2aXR5LnJlcG9ydF9pZCk7DQo+ID4gwqAJfQ0KPiA+ICsJaWYgKHN0LT5jb21tb25fYXR0cmli
dXRlcy5zZW5zaXRpdml0eS5pbmRleCA8IDApIHsNCj4gPiArCQlzZW5zb3JfaHViX2lucHV0X2dl
dF9hdHRyaWJ1dGVfaW5mbyhoc2RldiwNCj4gPiArCQkJSElEX0ZFQVRVUkVfUkVQT1JULCB1c2Fn
ZV9pZCwNCj4gPiArCQkJSElEX1VTQUdFX1NFTlNPUl9EQVRBX01PRF9DSEFOR0VfU0VOU0lUSVZJ
DQo+ID4gVFlfUkVMX1BDVCB8DQo+ID4gKwkJCUhJRF9VU0FHRV9TRU5TT1JfTElHSFRfSUxMVU0s
DQo+ID4gKwkJCSZzdC0+Y29tbW9uX2F0dHJpYnV0ZXMuc2Vuc2l0aXZpdHkpOw0KPiA+ICsJCWRl
dl9kYmcoJnBkZXYtPmRldiwgIlNlbnNpdGl2aXR5IGluZGV4OnJlcG9ydA0KPiA+ICVkOiVkXG4i
LA0KPiA+ICsJCQlzdC0+Y29tbW9uX2F0dHJpYnV0ZXMuc2Vuc2l0aXZpdHkuaW5kZXgsDQo+ID4g
KwkJCXN0LQ0KPiA+ID5jb21tb25fYXR0cmlidXRlcy5zZW5zaXRpdml0eS5yZXBvcnRfaWQpOw0K
PiA+ICsJfQ0KPiA+ICsNCj4gPiDCoAlyZXR1cm4gcmV0Ow0KPiA+IMKgfQ0KPiA+IMKgDQo+ID4g
ZGlmZiAtLWdpdCBhL2luY2x1ZGUvbGludXgvaGlkLXNlbnNvci1pZHMuaCBiL2luY2x1ZGUvbGlu
dXgvaGlkLQ0KPiA+IHNlbnNvci1pZHMuaA0KPiA+IGluZGV4IGYyZWU5MGEuLjc1NWY1ZTIgMTAw
NjQ0DQo+ID4gLS0tIGEvaW5jbHVkZS9saW51eC9oaWQtc2Vuc29yLWlkcy5oDQo+ID4gKysrIGIv
aW5jbHVkZS9saW51eC9oaWQtc2Vuc29yLWlkcy5oDQo+ID4gQEAgLTE0MSw2ICsxNDEsNyBAQA0K
PiA+IMKgLyogUGVyIGRhdGEgZmllbGQgcHJvcGVydGllcyAqLw0KPiA+IMKgI2RlZmluZSBISURf
VVNBR0VfU0VOU09SX0RBVEFfTU9EX05PTkUJCQkJDQo+ID4gCTB4MDANCj4gPiDCoCNkZWZpbmUg
SElEX1VTQUdFX1NFTlNPUl9EQVRBX01PRF9DSEFOR0VfU0VOU0lUSVZJVFlfQUJTCQkNCj4gPiAw
eDEwMDANCj4gPiArI2RlZmluZSBISURfVVNBR0VfU0VOU09SX0RBVEFfTU9EX0NIQU5HRV9TRU5T
SVRJVklUWV9SRUxfUENUCQ0KPiA+IAkweEUwMDANCj4gPiDCoA0KPiA+IMKgLyogUG93ZXIgc3Rh
dGUgZW51bWVyYXRpb25zICovDQo+ID4gwqAjZGVmaW5lIEhJRF9VU0FHRV9TRU5TT1JfUFJPUF9Q
T1dFUl9TVEFURV9VTkRFRklORURfRU5VTQkweA0KPiA+IDIwMDg1MA0KPiA+IA==

Re: [PATCH] iio: hid-sensor-als: Add realtime data type parse support

[Jonathan Cameron]

On 31/10/16 00:37, Pandruvada, Srinivas wrote:
> On Sun, 2016-10-30 at 16:26 +0000, Jonathan Cameron wrote:
>> On 28/10/16 02:20, Song Hongyan wrote:
>>>
>>> In parse report function it only support to parse absolute data
>>> type
>>> reported. Some platforms which report realtime data cannot be
>>> parsed,
>>> they will get "Invalid Argument" when try to get sensor data.
>>>
>>> Add realtime data type support to match different platforms.
>> I'm not 100% sure that rel stands for real time here...
>>
>> Relative percent?  There is also a percent of range option though no
>> idea if any hardware actually uses that.
>>
>> Srinivas, could you take a look at this one as well.
> I asked Hongyan to post to mailing list to seek some opinion.
> The IIO ABI hysteresis is absolute value, but this will specify a
> relative value with percentage.
> I think we need a new ABI.
Agreed.
> 
> Thanks,
> Srinivas
> 
> 
>>
>> thanks,
>>
>> Jonathan
>>>
>>>
>>> Signed-off-by: Song Hongyan <hongyan.song@intel.com>
>>> ---
>>>  drivers/iio/light/hid-sensor-als.c | 11 +++++++++++
>>>  include/linux/hid-sensor-ids.h     |  1 +
>>>  2 files changed, 12 insertions(+)
>>>
>>> diff --git a/drivers/iio/light/hid-sensor-als.c
>>> b/drivers/iio/light/hid-sensor-als.c
>>> index 8bb1f90..3b3aa66 100644
>>> --- a/drivers/iio/light/hid-sensor-als.c
>>> +++ b/drivers/iio/light/hid-sensor-als.c
>>> @@ -252,6 +252,17 @@ static int als_parse_report(struct
>>> platform_device *pdev,
>>>  			st->common_attributes.sensitivity.index,
>>>  			st-
>>>> common_attributes.sensitivity.report_id);
>>>  	}
>>> +	if (st->common_attributes.sensitivity.index < 0) {
>>> +		sensor_hub_input_get_attribute_info(hsdev,
>>> +			HID_FEATURE_REPORT, usage_id,
>>> +			HID_USAGE_SENSOR_DATA_MOD_CHANGE_SENSITIVI
>>> TY_REL_PCT |
>>> +			HID_USAGE_SENSOR_LIGHT_ILLUM,
>>> +			&st->common_attributes.sensitivity);
>>> +		dev_dbg(&pdev->dev, "Sensitivity index:report
>>> %d:%d\n",
>>> +			st->common_attributes.sensitivity.index,
>>> +			st-
>>>> common_attributes.sensitivity.report_id);
>>> +	}
>>> +
>>>  	return ret;
>>>  }
>>>  
>>> diff --git a/include/linux/hid-sensor-ids.h b/include/linux/hid-
>>> sensor-ids.h
>>> index f2ee90a..755f5e2 100644
>>> --- a/include/linux/hid-sensor-ids.h
>>> +++ b/include/linux/hid-sensor-ids.h
>>> @@ -141,6 +141,7 @@
>>>  /* Per data field properties */
>>>  #define HID_USAGE_SENSOR_DATA_MOD_NONE				
>>> 	0x00
>>>  #define HID_USAGE_SENSOR_DATA_MOD_CHANGE_SENSITIVITY_ABS		
>>> 0x1000
>>> +#define HID_USAGE_SENSOR_DATA_MOD_CHANGE_SENSITIVITY_REL_PCT	
>>> 	0xE000
>>>  
>>>  /* Power state enumerations */
>>>  #define HID_USAGE_SENSOR_PROP_POWER_STATE_UNDEFINED_ENUM	0x
>>> 200850