[PATCH] tools: iio: iio_generic_buffer: initialize channel array pointer

[PATCH] tools: iio: iio_generic_buffer: initialize channel array pointer

[Alison Schofield]

Uninitialized channel pointer causes segmentation fault when we
call free(channel) during cleanup() with no channels initialized.
This happens when you exit early for usage errors.  Initialize
the pointer to NULL when it is declared.

Signed-off-by: Alison Schofield <amsfield22@gmail.com>
Cc: Daniel Baluta <daniel.baluta@gmail.com>
---
 tools/iio/iio_generic_buffer.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/iio/iio_generic_buffer.c b/tools/iio/iio_generic_buffer.c
index 0e8a1f7..ae68bf0 100644
--- a/tools/iio/iio_generic_buffer.c
+++ b/tools/iio/iio_generic_buffer.c
@@ -348,7 +348,7 @@ int main(int argc, char **argv)
 	int notrigger = 0;
 	char *dummy;
 
-	struct iio_channel_info *channels;
+	struct iio_channel_info *channels = NULL;
 
 	register_cleanup();
 
-- 
2.1.4

Re: [PATCH] tools: iio: iio_generic_buffer: initialize channel array pointer

[Gregor Boirie]

On 07/27/2016 05:17 AM, Alison Schofield wrote:
> Uninitialized channel pointer causes segmentation fault when we
> call free(channel) during cleanup() with no channels initialized.
> This happens when you exit early for usage errors.  Initialize
> the pointer to NULL when it is declared.
>
> Signed-off-by: Alison Schofield <amsfield22@gmail.com>
> Cc: Daniel Baluta <daniel.baluta@gmail.com>
> ---
>   tools/iio/iio_generic_buffer.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/iio/iio_generic_buffer.c b/tools/iio/iio_generic_buffer.c
> index 0e8a1f7..ae68bf0 100644
> --- a/tools/iio/iio_generic_buffer.c
> +++ b/tools/iio/iio_generic_buffer.c
> @@ -348,7 +348,7 @@ int main(int argc, char **argv)
>   	int notrigger = 0;
>   	char *dummy;
>   
> -	struct iio_channel_info *channels;
> +	struct iio_channel_info *channels = NULL;
>   
>   	register_cleanup();
>   
Tested-by: Gregor Boirie <gregor.boirie@parrot.com>

greg.

Re: [PATCH] tools: iio: iio_generic_buffer: initialize channel array pointer

[Jonathan Cameron]

On 27/07/16 09:12, Gregor Boirie wrote:
> 
> On 07/27/2016 05:17 AM, Alison Schofield wrote:
>> Uninitialized channel pointer causes segmentation fault when we
>> call free(channel) during cleanup() with no channels initialized.
>> This happens when you exit early for usage errors.  Initialize
>> the pointer to NULL when it is declared.
>>
>> Signed-off-by: Alison Schofield <amsfield22@gmail.com>
>> Cc: Daniel Baluta <daniel.baluta@gmail.com>
>> ---
>>   tools/iio/iio_generic_buffer.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/tools/iio/iio_generic_buffer.c b/tools/iio/iio_generic_buffer.c
>> index 0e8a1f7..ae68bf0 100644
>> --- a/tools/iio/iio_generic_buffer.c
>> +++ b/tools/iio/iio_generic_buffer.c
>> @@ -348,7 +348,7 @@ int main(int argc, char **argv)
>>       int notrigger = 0;
>>       char *dummy;
>>   -    struct iio_channel_info *channels;
>> +    struct iio_channel_info *channels = NULL;
>>         register_cleanup();
>>   
> Tested-by: Gregor Boirie <gregor.boirie@parrot.com>
I'm not marking this for stable purely because the huge about of
churn in those files makes it tricky to be sure when it first
broke or if it was always broken!

Anyhow, applied to the fixes-togreg branch of iio.git.

Thanks,

Jonathan
> 
> greg.
> -- 
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html