From: Javier Carrasco <javier.carrasco.cruz@gmail.com>
To: Matti Vaittinen <mazziesaccount@gmail.com>,
Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
Cc: Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] iio: bu27034: simplify using guard(mutex)
Date: Fri, 22 Nov 2024 07:40:53 +0100 [thread overview]
Message-ID: <416d2029-7678-4a3b-9980-92afbbb49875@gmail.com> (raw)
In-Reply-To: <4e65a4725c211b166906f70fdb5ba90f2af0f570.1732193263.git.mazziesaccount@gmail.com>
On 21/11/2024 14:05, Matti Vaittinen wrote:
> The BU27034 uses mutex for protecting the gain / time / scale changes.
> The clean-up for a few of the functions can be slightly simplified by
> removing the goto-based error handling/unlocking and by utilizing the
> guard(mutex) scoped mutex handling instead.
>
> Simplify driver by using the scoped mutexes.
>
> Signed-off-by: Matti Vaittinen <mazziesaccount@gmail.com>
> ---
> drivers/iio/light/rohm-bu27034.c | 73 +++++++++++---------------------
> 1 file changed, 25 insertions(+), 48 deletions(-)
>
Reviewed-by: Javier Carrasco <javier.carrasco.cruz@gmail.com>
next prev parent reply other threads:[~2024-11-22 6:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-21 13:04 [PATCH 0/2] iio: Use __cleanup for a few ROHM sensors Matti Vaittinen
2024-11-21 13:05 ` [PATCH 1/2] iio: bu27034: simplify using guard(mutex) Matti Vaittinen
2024-11-22 6:40 ` Javier Carrasco [this message]
2024-11-21 13:05 ` [PATCH 2/2] iio: bm1390: " Matti Vaittinen
2024-11-22 6:41 ` Javier Carrasco
2024-11-21 13:54 ` [PATCH 0/2] iio: Use __cleanup for a few ROHM sensors Javier Carrasco
2024-11-22 6:10 ` Matti Vaittinen
2024-11-22 6:40 ` Javier Carrasco
2024-11-23 16:46 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=416d2029-7678-4a3b-9980-92afbbb49875@gmail.com \
--to=javier.carrasco.cruz@gmail.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matti.vaittinen@fi.rohmeurope.com \
--cc=mazziesaccount@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox