linux-iio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Cretaro <paolocretaro@gmail.com>
To: Jonathan Cameron <jic23@kernel.org>
Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
	Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Subject: Re: [PATCH] iio: adc: meson-saradc: use NULL instead of 0 for pointer
Date: Sun, 28 May 2017 19:52:33 +0200	[thread overview]
Message-ID: <41db6c75-c29b-8c58-ff6d-126969dbce38@gmail.com> (raw)
In-Reply-To: <20170528154309.243555e3@kernel.org>

On 28/05/2017 16:43, Jonathan Cameron wrote:
> On Sun, 28 May 2017 13:24:38 +0200
> Paolo Cretaro <paolocretaro@gmail.com> wrote:
> 
>> Fix sparse warning: Using plain integer as NULL pointer
>>
>> Signed-off-by: Paolo Cretaro <paolocretaro@gmail.com>
> This looks fine to me, but ideally you should always try to include
> the driver author - particularly in the case of patches to a recent
> driver such as this one.
Sure, thanks for pointing this out, I just felt a bit embarrassed to bother
too many people with such a trivial patch.

Paolo
> 
> To that end I've cc'd Martin.
> 
> Jonathan
>> ---
>>  drivers/iio/adc/meson_saradc.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/iio/adc/meson_saradc.c b/drivers/iio/adc/meson_saradc.c
>> index 81cd39a57fe3..fb3f67a9ae1f 100644
>> --- a/drivers/iio/adc/meson_saradc.c
>> +++ b/drivers/iio/adc/meson_saradc.c
>> @@ -481,7 +481,7 @@ static void meson_sar_adc_clear_fifo(struct iio_dev *indio_dev)
>>  		if (!meson_sar_adc_get_fifo_count(indio_dev))
>>  			break;
>>  
>> -		regmap_read(priv->regmap, MESON_SAR_ADC_FIFO_RD, 0);
>> +		regmap_read(priv->regmap, MESON_SAR_ADC_FIFO_RD, NULL);
>>  	}
>>  }
>>  
> 

  reply	other threads:[~2017-05-28 17:52 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-28 11:24 [PATCH] iio: adc: meson-saradc: use NULL instead of 0 for pointer Paolo Cretaro
2017-05-28 14:43 ` Jonathan Cameron
2017-05-28 17:52   ` Paolo Cretaro [this message]
2017-05-28 21:17   ` Martin Blumenstingl
2017-06-03  8:52     ` Jonathan Cameron
2017-06-04 13:32       ` Martin Blumenstingl
2017-06-06  9:28         ` Paolo Cretaro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=41db6c75-c29b-8c58-ff6d-126969dbce38@gmail.com \
    --to=paolocretaro@gmail.com \
    --cc=jic23@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=martin.blumenstingl@googlemail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).