From: David Lechner <dlechner@baylibre.com>
To: Aldo Conte <aldocontelk@gmail.com>, linux-iio@vger.kernel.org
Cc: "Jonathan Cameron" <jic23@kernel.org>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [RFC] iio: light: tcs3472: implementing wait time TODO
Date: Sat, 25 Apr 2026 11:49:35 -0500 [thread overview]
Message-ID: <46fd475f-8d54-4419-a195-d66c947fcc1b@baylibre.com> (raw)
In-Reply-To: <73d2183e-dffe-4ae4-9312-c544e0079f3a@gmail.com>
On 4/25/26 11:28 AM, Aldo Conte wrote:
> Hi all,
>
> I'd like to resolve the wait time TODO in tcs3472.c.
Do you actually have this hardware to test it?
What is the application that needs to make use of this feature?
>
> The TCS3472 has a WTIME register and WEN bit that insert a low-power
What about WLONG?
> wait state between RGBC cycles. The register is already defined in the driver but never used.
> I noticed that tsl2772.c enables wait with a fixed default and no
> userspace control. However, I think exposing the wait time to
> userspace would be more useful to tune the power/responsiveness tradeoff.
I assume this would affect the effective sample rate?
>
> My plan would be to expose it via an ext_info attribute in
> microseconds, following the same convention as integration_time.
> Does that sound acceptable, or would you prefer a simpler approach
> with just a fixed default like tsl2772?
So perhaps we could just use the standard sampling_frequency attribute?
>
> I also plan a following patch converting the driver to devm.
Would be better to do this first before adding new features.
>
> Thanks,
> Aldo
>
next prev parent reply other threads:[~2026-04-25 16:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-25 16:28 [RFC] iio: light: tcs3472: implementing wait time TODO Aldo Conte
2026-04-25 16:49 ` David Lechner [this message]
2026-04-25 19:00 ` Aldo Conte
2026-04-25 23:11 ` David Lechner
2026-04-26 10:48 ` Jonathan Cameron
2026-04-26 14:37 ` Aldo Conte
2026-04-26 15:51 ` David Lechner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46fd475f-8d54-4419-a195-d66c947fcc1b@baylibre.com \
--to=dlechner@baylibre.com \
--cc=aldocontelk@gmail.com \
--cc=andy@kernel.org \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox