From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f172.google.com (mail-pf1-f172.google.com [209.85.210.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E7FC23A1DA for ; Mon, 22 Jan 2024 10:07:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705918062; cv=none; b=YFjyoNhWh7LF79YV8P9TJo2S2inFiHldXm4l0equfpkP/SfVIEhEWXqAyKaxLKiFA5I+6s3cYMoTF2+BVFoVJcY1xno3/JrO7gdkD5hzVuvS9Y7zThIWUlZnBDEBPMFk85YlcsFYXj2V/5tlKc5DdcOXf4cFeF6SI7x+o/YlPbI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705918062; c=relaxed/simple; bh=7hfseNti4KOg7rK9baauGbMNt7pApk4b65kBVK61lRM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=RsHtgrWeceWMDSXozcZn/ue5eFv0cvwWpI71iygmL7vNK8yeUi4FotQYgYos48x+jRJ+bPgEJig7DJKBIFDBz2m6DDl+cYWsNgisWOyezpQa3oyE67lvpuyRMLQwbK+5GPxlLz/khnBhwinynl9YR2qEvFeabWBoFaA2tIXv9Cc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tweaklogic.com; spf=pass smtp.mailfrom=tweaklogic.com; dkim=pass (2048-bit key) header.d=tweaklogic.com header.i=@tweaklogic.com header.b=OfRjt8QW; arc=none smtp.client-ip=209.85.210.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tweaklogic.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=tweaklogic.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=tweaklogic.com header.i=@tweaklogic.com header.b="OfRjt8QW" Received: by mail-pf1-f172.google.com with SMTP id d2e1a72fcca58-6db9e52bbccso1392159b3a.3 for ; Mon, 22 Jan 2024 02:07:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tweaklogic.com; s=google; t=1705918060; x=1706522860; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=7SZ6TVtvqO7xS+FN5Shbzs8pDYcUTB61xRBtZe0By+M=; b=OfRjt8QWrGSQCDS9EbbbtG+FrNaVTL6vPTnUtshkgbUB19HjnZEumH4sKuKYnaN1Zx FsLKoKGueE/+xeL9S0a/cGimMfbRuPbC/wnRry43IaV1n9NxGSfhnyJkMLEueO1q+z59 CmNev0L+hFeNv9F3GW+7LBImF9OY5yVBZmshcXSecGloHjovUvtrAzyKomeEDinJ6h3n HrEK9glHVQLoQsZd4JJzoq6nr5uiOsY9rar0li+QnkYMILC/v82Rp/9XkqKuIftvIu13 6QY6vADYa8GXc9M5LKyNY8fDS21KwImF6NozidqSiSf5LdtGiPilsBELp8DcUMFNHtIS Tekw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705918060; x=1706522860; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=7SZ6TVtvqO7xS+FN5Shbzs8pDYcUTB61xRBtZe0By+M=; b=G7gOkgtpE4ukMgwnHtO7eDAMw557RPiZ1AUOSvCFl+yPHjZwbofQG0yp7MNsPnAI/9 Tjc4M0Fc22wgWjt55XHTJFP/LkXXOZuFpEUfkSgZVlTd/xwSc0z9GPoQNBafn9+3WzbN D0kZayIBi+gEiT6fzNMXs+jI7nvK6dMbP9ocy+IFXdRYY5yDV6X0iHeD3mm0FIQ2qd6y UPLJRsuv442HgwM8EOcQtpyHEO9NOpasanHiiw7yDXaGzgy2EAiUEbaqo4BEINlfVXUL q85ewrEjsqkPcdxPlMTrNceNLpNiJwTyX4cXQSdT/GCv5uJ59H9GmDOP16+J6OzyN9gX cfsA== X-Gm-Message-State: AOJu0YyLnGOQgCrD4uCf9R6FSfXw2d1UKzVirhj6rXwjLCZ20r7OHUhB THcUGf3WNyXMnhJC3if6QZfni5YNuuJGHvIHHi9riLYRfayvDsR0bM9QiOQqkBs= X-Google-Smtp-Source: AGHT+IFOmDwDqyifPwJRFILel0xXFOZg55zuqJ0ufInqRPYJxdwGgQjTGWuazVH1pqkRIehl9L8Msw== X-Received: by 2002:a17:903:1251:b0:1d7:657:8ab1 with SMTP id u17-20020a170903125100b001d706578ab1mr1864860plh.76.1705918060314; Mon, 22 Jan 2024 02:07:40 -0800 (PST) Received: from [192.168.20.11] ([180.150.112.156]) by smtp.gmail.com with ESMTPSA id w14-20020a170902a70e00b001d75c26e857sm811322plq.288.2024.01.22.02.07.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 22 Jan 2024 02:07:39 -0800 (PST) Message-ID: <478fc1b0-aba4-4f36-bdb6-bf5fc7eb8609@tweaklogic.com> Date: Mon, 22 Jan 2024 20:37:32 +1030 Precedence: bulk X-Mailing-List: linux-iio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 2/3] dt-bindings: iio: light: Avago APDS9306 Content-Language: en-US To: Krzysztof Kozlowski , Jonathan Cameron , Lars-Peter Clausen , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matti Vaittinen , Andy Shevchenko , Marek Vasut , Anshul Dalal , Javier Carrasco Cc: Matt Ranostay , Stefan Windfeldt-Prytz , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20240121051735.32246-1-subhajit.ghosh@tweaklogic.com> <20240121051735.32246-3-subhajit.ghosh@tweaklogic.com> From: Subhajit Ghosh In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 22/1/24 20:21, Krzysztof Kozlowski wrote: > On 21/01/2024 06:17, Subhajit Ghosh wrote: >> Adding device tree support for APDS9306 Ambient Light Sensor. >> Updating datasheet hyperlinks. >> Adding interrupt definition macro and header file. >> Adding vdd-supply property. > > Why? Do other devices have it? Are you referring to vdd-supply? No, I guess, haven't checked actually. If other devices don't have, can you suggest the best way to handle that? > > >> required: >> @@ -33,6 +37,8 @@ required: >> >> examples: >> - | >> + #include >> + >> i2c { >> #address-cells = <1>; >> #size-cells = <0>; >> @@ -41,7 +47,8 @@ examples: >> compatible = "avago,apds9300"; >> reg = <0x39>; >> interrupt-parent = <&gpio2>; >> - interrupts = <29 8>; >> + interrupts = <29 IRQ_TYPE_LEVEL_LOW>; > > Separate change. Understood. > > Best regards, > Krzysztof > Regards, Subhajit Ghosh