From: Lars-Peter Clausen <lars@metafoo.de>
To: Randy Dunlap <rdunlap@infradead.org>,
Dan Carpenter <error27@gmail.com>,
Menna Mahmoud <eng.mennamahmoud.mm@gmail.com>
Cc: Michael.Hennerich@analog.com, jic23@kernel.org,
gregkh@linuxfoundation.org, linux-iio@vger.kernel.org,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
Outreachy Linux Kernel <outreachy@lists.linux.dev>
Subject: Re: Outreachy
Date: Wed, 15 Mar 2023 13:09:29 -0700 [thread overview]
Message-ID: <48571e97-8766-e67d-c263-29fd67a31f06@metafoo.de> (raw)
In-Reply-To: <cdb828ad-855d-f7bc-d23e-17ed50750768@infradead.org>
On 3/15/23 12:24, Randy Dunlap wrote:
>
> On 3/15/23 07:03, Dan Carpenter wrote:
>> On Wed, Mar 15, 2023 at 03:17:28PM +0200, Menna Mahmoud wrote:
>>> Hi Mentors,
>>>
>>>
>>> I am Menna, Outreachy applicant and I work on my clean-up patches.
>>>
>>> Is it Okay to work on this error reported by checkpatch script?
>>>
>>>
>>> drivers/staging/iio/frequency/ad9832.c
>>> --------------------------------------
>>> ERROR: Use 4 digit octal (0777) not decimal permissions
>>> #256: FILE: drivers/staging/iio/frequency/ad9832.c:256:
>>> +static IIO_DEV_ATTR_FREQ(0, 1, 0200, NULL, ad9832_write, AD9832_FREQ1HM);
>> What??? Is it complaining about the 0200? That is octal. Why is
>> checkpatch complaining about this? Am I wrong? Maybe I am misreading.
>>
>> I could investigate, but I am leaving that task to you. It may be that
>> checkpatch has a problem and you can fix that instead.
>>
> Yes, checkpatch seems to be confused here.
It seems to make an assumption that everything starting with
IIO_DEV_ATTR_ has the mode field at the same position. Which is not the
case.
https://github.com/torvalds/linux/blob/master/scripts/checkpatch.pl#L798
Still a good target to get this fixed as part of a outreachy task.
next prev parent reply other threads:[~2023-03-15 20:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-15 13:17 Outreachy Menna Mahmoud
2023-03-15 14:03 ` Outreachy Dan Carpenter
2023-03-15 19:24 ` Outreachy Randy Dunlap
2023-03-15 20:09 ` Lars-Peter Clausen [this message]
2023-03-19 11:20 ` Outreachy Menna Mahmoud
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48571e97-8766-e67d-c263-29fd67a31f06@metafoo.de \
--to=lars@metafoo.de \
--cc=Michael.Hennerich@analog.com \
--cc=eng.mennamahmoud.mm@gmail.com \
--cc=error27@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=outreachy@lists.linux.dev \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox