From: Jonathan Cameron <jic23@cam.ac.uk>
To: achew@nvidia.com
Cc: linux-iio@vger.kernel.org
Subject: Re: [PATCH 1/1] iio: Change GAIN macros to SCALE.
Date: Sun, 05 Sep 2010 23:33:49 +0100 [thread overview]
Message-ID: <4C841ACD.2080809@cam.ac.uk> (raw)
In-Reply-To: <1283724326-31998-1-git-send-email-achew@nvidia.com>
On 09/05/10 23:05, achew@nvidia.com wrote:
> From: Andrew Chew <achew@nvidia.com>
>
> Per email exchange with Jonathan Cameron, GAIN should instead be SCALE, to
> be consistent with documentation.
>
> Signed-off-by: Andrew Chew <achew@nvidia.com>
Acked-by: Jonathan Cameron <jic23@cam.ac.uk>
Please send this one on to Greg KH with your driver
(when that is ready). That will make it apparent why
these are there at all!
Thanks,
Jonathan
> ---
> drivers/staging/iio/magnetometer/magnet.h | 12 ++++++------
> 1 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/staging/iio/magnetometer/magnet.h b/drivers/staging/iio/magnetometer/magnet.h
> index 6433830..1260eb7 100644
> --- a/drivers/staging/iio/magnetometer/magnet.h
> +++ b/drivers/staging/iio/magnetometer/magnet.h
> @@ -12,14 +12,14 @@
> #define IIO_DEV_ATTR_MAGN_Z_OFFSET(_mode, _show, _store, _addr) \
> IIO_DEVICE_ATTR(magn_z_offset, _mode, _show, _store, _addr)
>
> -#define IIO_DEV_ATTR_MAGN_X_GAIN(_mode, _show, _store, _addr) \
> - IIO_DEVICE_ATTR(magn_x_gain, _mode, _show, _store, _addr)
> +#define IIO_DEV_ATTR_MAGN_X_SCALE(_mode, _show, _store, _addr) \
> + IIO_DEVICE_ATTR(magn_x_scale, _mode, _show, _store, _addr)
>
> -#define IIO_DEV_ATTR_MAGN_Y_GAIN(_mode, _show, _store, _addr) \
> - IIO_DEVICE_ATTR(magn_y_gain, _mode, _show, _store, _addr)
> +#define IIO_DEV_ATTR_MAGN_Y_SCALE(_mode, _show, _store, _addr) \
> + IIO_DEVICE_ATTR(magn_y_scale, _mode, _show, _store, _addr)
>
> -#define IIO_DEV_ATTR_MAGN_Z_GAIN(_mode, _show, _store, _addr) \
> - IIO_DEVICE_ATTR(magn_z_gain, _mode, _show, _store, _addr)
> +#define IIO_DEV_ATTR_MAGN_Z_SCALE(_mode, _show, _store, _addr) \
> + IIO_DEVICE_ATTR(magn_z_scale, _mode, _show, _store, _addr)
>
> #define IIO_DEV_ATTR_MAGN_X(_show, _addr) \
> IIO_DEVICE_ATTR(magn_x_raw, S_IRUGO, _show, NULL, _addr)
prev parent reply other threads:[~2010-09-05 22:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-05 22:05 [PATCH 1/1] iio: Change GAIN macros to SCALE achew
2010-09-05 22:33 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C841ACD.2080809@cam.ac.uk \
--to=jic23@cam.ac.uk \
--cc=achew@nvidia.com \
--cc=linux-iio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox