From: Jonathan Cameron <jic23@cam.ac.uk>
To: Jonathan Cameron <jic23@cam.ac.uk>
Cc: linux-iio@vger.kernel.org, Michael.Hennerich@analog.com,
Robin.Getz@analog.com, manuel.stahl@iis.fraunhofer.de
Subject: Re: [PATCH 6/6] staging:iio:adis16400 merge into adis16350 driver
Date: Sat, 11 Sep 2010 16:05:30 +0100 [thread overview]
Message-ID: <4C8B9ABA.7090607@cam.ac.uk> (raw)
In-Reply-To: <1284217100-2469-7-git-send-email-jic23@cam.ac.uk>
On 09/11/10 15:58, Jonathan Cameron wrote:
> Results in a subtle change to numbering of scan elements on
> the adis16350. This does not technically change the abi as
> these numbers are only guaranteed to be in the correct order,
> not to have particular values.
>
> Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk>
> ---
> drivers/staging/iio/imu/Kconfig | 13 +-
> drivers/staging/iio/imu/Makefile | 4 -
> drivers/staging/iio/imu/adis16350.h | 18 +-
> drivers/staging/iio/imu/adis16350_core.c | 69 +++
> drivers/staging/iio/imu/adis16350_ring.c | 33 ++-
> drivers/staging/iio/imu/adis16400.h | 208 --------
> drivers/staging/iio/imu/adis16400_core.c | 752 ------------------------------
> drivers/staging/iio/imu/adis16400_ring.c | 231 ---------
> 8 files changed, 116 insertions(+), 1212 deletions(-)
>
And here I go again. This one should also delete the adis16400_trigger.c file which is
no longer used. Doh. Changes the stats to:
drivers/staging/iio/imu/Kconfig | 13 +-
drivers/staging/iio/imu/Makefile | 4 -
drivers/staging/iio/imu/adis16350.h | 18 +-
drivers/staging/iio/imu/adis16350_core.c | 69 +++
drivers/staging/iio/imu/adis16350_ring.c | 33 ++-
drivers/staging/iio/imu/adis16400.h | 208 --------
drivers/staging/iio/imu/adis16400_core.c | 752 ---------------------------
drivers/staging/iio/imu/adis16400_ring.c | 231 --------
drivers/staging/iio/imu/adis16400_trigger.c | 125 -----
9 files changed, 116 insertions(+), 1337 deletions(-)
Now these are the kind of patch statistics that people like ;)
There is also a subtle difference in here I forgot to mention. Their is no longer a device
id check on probe. I can put this back in if people would like it. It wasn't ever there in
the adis16350 as far as I know...
Jonathan
next prev parent reply other threads:[~2010-09-11 15:05 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-11 14:58 [RFC PATCH 0/6] staging:iio:imu driver merges, fixes and new features Jonathan Cameron
2010-09-11 14:58 ` [PATCH 1/6] staging:iio:adis16350 add non burst buffer fill and fix burst logic Jonathan Cameron
2010-09-11 14:58 ` [PATCH 2/6] staging:iio:adis16350 move datardy trigger to straight interrupt Jonathan Cameron
2010-09-11 14:58 ` [PATCH 3/6] staging:iio:adis16350 Add optional event support Jonathan Cameron
2010-09-11 14:58 ` [PATCH 4/6] staging:iio:adis16350 add missing registration of temp_offset attr Jonathan Cameron
2010-09-11 14:58 ` [PATCH 5/6] staging:iio:adis16300 merge into adis16350 driver Jonathan Cameron
2010-09-18 16:06 ` Jonathan Cameron
2010-09-11 14:58 ` [PATCH 6/6] staging:iio:adis16400 " Jonathan Cameron
2010-09-11 15:05 ` Jonathan Cameron [this message]
2010-09-22 8:47 ` [RFC PATCH 0/6] staging:iio:imu driver merges, fixes and new features Manuel Stahl
2010-09-22 10:12 ` Jonathan Cameron
2010-09-22 10:17 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C8B9ABA.7090607@cam.ac.uk \
--to=jic23@cam.ac.uk \
--cc=Michael.Hennerich@analog.com \
--cc=Robin.Getz@analog.com \
--cc=linux-iio@vger.kernel.org \
--cc=manuel.stahl@iis.fraunhofer.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox