From: Jonathan Cameron <jic23@cam.ac.uk>
To: David Brownell <david-b@pacbell.net>
Cc: Grant Likely <grant.likely@secretlab.ca>,
drivers@analog.com,
David Brownell <dbrownell@users.sourceforge.net>,
linux-iio@vger.kernel.org,
Nicolas Ferre <nicolas.ferre@atmel.com>,
matthias <mensch0815@googlemail.com>,
spi-devel-general@lists.sourceforge.net
Subject: Re: [PATCH 0/2 V2] Adding support for adis16250/5 to adis16260 driver.
Date: Sat, 09 Oct 2010 11:24:27 +0100 [thread overview]
Message-ID: <4CB042DB.6020500@cam.ac.uk> (raw)
In-Reply-To: <1286568720.1723.4.camel@helium>
On 10/08/10 21:12, David Brownell wrote:
> On Fri, 2010-10-08 at 12:29 -0600, Grant Likely wrote:
>> On Fri, Oct 08, 2010 at 12:22:28PM +0100, Jonathan Cameron wrote:
>
>>> Is it ever wrong to over specify elements of a transfer?
>
> I wouldn't say that's even possible.
>
>>> We have a driver that (for historical reasons) specifies
>>> that a particular transfer is 8 bit.
>>> .bits_per_word = 8,
>>>
>>> This causes issues with the atmel spi driver which sees that
>>> the value is specified and hence fails the transfer.
>
>
> Specifying 8 there means the same as specifying zero.
Cool,
I'll post a patch (probably Monday now) to at least ensure the
atmel driver lets transfers through if we aren't trying to change
bits_per_word.
Thanks for getting back to us.
Jonathan
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2010-10-09 10:18 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-06 15:16 [PATCH 0/2 V2] Adding support for adis16250/5 to adis16260 driver Jonathan Cameron
2010-09-06 15:16 ` [PATCH 1/2] staging:iio:adis16260 add id table support Jonathan Cameron
2010-09-06 15:16 ` [PATCH 2/2] staging:iio:adis16260 add suppport for adis16255 and adis16250 Jonathan Cameron
2010-09-18 12:46 ` [PATCH 0/2 V2] Adding support for adis16250/5 to adis16260 driver Jonathan Cameron
2010-09-18 15:48 ` matthias
2010-09-27 16:34 ` Jonathan Cameron
2010-09-28 20:56 ` matthias
2010-09-29 13:52 ` Jonathan Cameron
2010-10-08 11:22 ` Jonathan Cameron
2010-10-08 18:29 ` Grant Likely
2010-10-08 20:12 ` David Brownell
2010-10-09 10:24 ` Jonathan Cameron [this message]
[not found] ` <AANLkTikKQdxi3CWGinkJ6GMSmFZOLQ75-62LugkUAz-p@mail.gmail.com>
[not found] ` <4CB6E04F.4000208@cam.ac.uk>
[not found] ` <AANLkTikM4Cvr=utxCkUzyBPbm9gHkd_kTc0gpq3_Zurn@mail.gmail.com>
[not found] ` <4CB6E93A.3080402@cam.ac.uk>
2010-11-12 17:10 ` matthias
2010-11-18 14:18 ` Jonathan Cameron
2010-11-23 17:47 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CB042DB.6020500@cam.ac.uk \
--to=jic23@cam.ac.uk \
--cc=david-b@pacbell.net \
--cc=dbrownell@users.sourceforge.net \
--cc=drivers@analog.com \
--cc=grant.likely@secretlab.ca \
--cc=linux-iio@vger.kernel.org \
--cc=mensch0815@googlemail.com \
--cc=nicolas.ferre@atmel.com \
--cc=spi-devel-general@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox