Hi,

On 01/11/2011 08:34 PM, Jonathan Cameron wrote:
>> On 01/09/2011 11:31 PM, Jonathan Cameron wrote:
>>> Pretty clean and nice driver so it was an easy review and should
>>> be trivial to fix up for a merge.
>>
>> Thanks for your review!
>>
>> I'm attaching my update. Some notes:
>>
>> * I used the attributes out1_* how I found it in the other DAC driver
>> already available
> Cool, except for the out12_raw which could easily be the 12th channel.
> This has to be one of the two options suggested the other day.
> May require some macro magic. IIRC the relevant macro would be.
> 
> IIO_DEVICE_ATTR_NAMED(out1and2_raw, out1&2_raw, S_IWUSR, ... 

Update attached as suggested. :-)

Thanks!

Roland