From: Jonathan Cameron <jic23@cam.ac.uk>
To: Jean Delvare <khali@linux-fr.org>
Cc: Andrew Chew <AChew@nvidia.com>,
chinyeow.sim.xt@renesas.com, gregkh@suse.de,
devel@driverdev.osuosl.org, linux-iio@vger.kernel.org
Subject: Re: [RFC PATCH] staging: ak8975: add platform data.
Date: Tue, 22 Feb 2011 12:35:13 +0000 [thread overview]
Message-ID: <4D63AD81.5080903@cam.ac.uk> (raw)
In-Reply-To: <20110222102955.52be2b94@endymion.delvare>
On 02/22/11 09:29, Jean Delvare wrote:
> Hi Jonathan,
>
> On Mon, 21 Feb 2011 16:10:14 +0000, Jonathan Cameron wrote:
>> On 02/15/11 20:49, Andrew Chew wrote:
>>>> As some of the platform not support irq_to_gpio, we pass gpio port
>>>> by platform data.
>>>
>>> Looks good to me.
>>>
>>> Signed-off-by: Andrew Chew <achew@nvidia.com>
>> Firstly, please cc linux-iio for patches effecting iio drivers.
>>
>> Hmm.. It's a bit of a pain that i2c devices don't take platform resources
>> or we could avoid doing this entirely. I have a vague recollection of this
>> being suggested in the past, but never happening (might have been for spi
>> rather than i2c though...) Jean, can you comment on this?
>
> I fear I don't have the slightest idea of what you're talking about.
> "Taking platform resources"?
Sorry, I should have written a proper description of what I meant.
Add to i2c_board_info the following
struct resource *resource;
which is defined in ioport.h
I thought this actually allowed for gpio's but right now can't figure out how
to handle them. What it definitely does handle cleanly is devices with multiple
irq's.
You basically get to query for resources by name so can pass lots of 'platform data'
type stuff without having to define a specific structure for passing it in.
>
>> Dmitry isn't going to want that header in the linux/input directory.
>
> And he would be right. Header files containing platform data structures
> for i2c device drivers go to include/linux/i2c.
Cool. I'd kind of assumed they moved out when i2c/chips went away, but never
actually checked!
>
next prev parent reply other threads:[~2011-02-22 12:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1297764627-21077-1-git-send-email-chinyeow.sim.xt@renesas.com>
[not found] ` <643E69AA4436674C8F39DCC2C05F763816BD96CFB5@HQMAIL03.nvidia.com>
2011-02-21 16:10 ` [RFC PATCH] staging: ak8975: add platform data Jonathan Cameron
2011-02-22 9:29 ` Jean Delvare
2011-02-22 12:35 ` Jonathan Cameron [this message]
2011-02-22 21:55 ` Mark Brown
2011-02-23 8:19 ` Jean Delvare
2011-02-23 15:41 ` Bill Gatliff
2011-02-23 20:10 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D63AD81.5080903@cam.ac.uk \
--to=jic23@cam.ac.uk \
--cc=AChew@nvidia.com \
--cc=chinyeow.sim.xt@renesas.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@suse.de \
--cc=khali@linux-fr.org \
--cc=linux-iio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox