From: Jonathan Cameron <jic23@cam.ac.uk>
To: Jonathan Cameron <jic23@cam.ac.uk>
Cc: linux-iio@vger.kernel.org, arnd@arndb.de
Subject: Re: [PATCH 0/8] staging:iio:mixed bag of fixes and cleanups.
Date: Tue, 12 Apr 2011 19:37:52 +0100 [thread overview]
Message-ID: <4DA49C00.7070606@cam.ac.uk> (raw)
In-Reply-To: <1300395627-18547-1-git-send-email-jic23@cam.ac.uk>
On 03/17/11 21:00, Jonathan Cameron wrote:
> I should probably have broken these up into more coherent subsets
> and made at least the allocate priv_data one an RFC.
> May do so before sending on to Greg.
>
> Patches 3, 4 and 6 are direct results of suggestions from Arnd Bergmann.
> Basically it's the easy bits of the discussion before we get onto
> the more 'interesting' ones.
>
> 1, 2 are things I spotted whilst working on the irq_chip stuff
> Thomas Gleixner suggested. They are just cleanups of some bizare
> corners. That rewrite of triggers currently requires some
> exports to be added to allow a modular build and I need to chase
> down whether we are simply the first people to have a reasonable
> case for it, or whether there is something more fundamental
> going on.
>
> The others are bugs / cleanups I came across whilst hammering
> max1363 with the new example code. Some of the timestamp bit
> was pointed out by Michael Hennerich a while back, but turns
> out the driver was broken as well as not obeying the ABI.
>
> Thanks,
Gone to Greg. Note this set will break any drivers that are currently
out of tree. Simplest fix is trivial
iio_allocate_device() -> iio_allocate_device(0)
Note for new drivers I'll be encouraging people to use the new
allocation stuff though.
Jonathan
next prev parent reply other threads:[~2011-04-12 18:37 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-17 21:00 [PATCH 0/8] staging:iio:mixed bag of fixes and cleanups Jonathan Cameron
2011-03-17 21:00 ` [PATCH 1/8] staging:iio:trigger remove export of iio_trigger_find_by_name, use sysfs_streq for matching Jonathan Cameron
2011-03-17 21:00 ` [PATCH 2/8] staging:iio: iio_trigger_unregister - remove rather strange search for what we already have Jonathan Cameron
2011-03-17 21:00 ` [PATCH 3/8] staging:iio: replace rip_lots naming with read_first_n Jonathan Cameron
2011-03-17 21:00 ` [PATCH 4/8] staging:iio: Add ability to allocate private data space to iio_allocate_device Jonathan Cameron
2011-03-17 22:08 ` Arnd Bergmann
2011-03-17 21:00 ` [PATCH 5/8] staging:iio:adc:max1363 fix timestamp handling Jonathan Cameron
2011-03-17 21:00 ` [PATCH 6/8] staging:iio:adc: max1363 dev_info -> indio_dev in naming for consistency Jonathan Cameron
2011-03-17 21:00 ` [PATCH 7/8] staging:iio:max1363 take advantage of new iio_device_allocate private data Jonathan Cameron
2011-03-17 21:00 ` [PATCH 8/8] staging:iio:documentation make read_size signed to allow for errors Jonathan Cameron
2011-04-12 18:37 ` Jonathan Cameron [this message]
2011-04-15 17:02 ` [PATCH 0/8] staging:iio:mixed bag of fixes and cleanups Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DA49C00.7070606@cam.ac.uk \
--to=jic23@cam.ac.uk \
--cc=arnd@arndb.de \
--cc=linux-iio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox