Linux IIO development
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@cam.ac.uk>
To: michael.hennerich@analog.com
Cc: linux-iio@vger.kernel.org, drivers@analog.com,
	device-drivers-devel@blackfin.uclinux.org
Subject: Re: [PATCH] IIO-onwards: trigger: iio-trig-sysfs: Avoid double free.
Date: Fri, 15 Apr 2011 13:53:09 +0100	[thread overview]
Message-ID: <4DA83FB5.7000501@cam.ac.uk> (raw)
In-Reply-To: <1302870582-14958-1-git-send-email-michael.hennerich@analog.com>

On 04/15/11 13:29, michael.hennerich@analog.com wrote:
> From: Michael Hennerich <michael.hennerich@analog.com>
> 
> 
Good catch.

Given I haven't 'officially' posted this lot yet, do you mind
if I merge the fixes into the patch that caused the problem?
(with crediting of course!)

Could keep them separate but that will make for confusing reviewing
once I haven't posted the patches.. (probably later today).

> Signed-off-by: Michael Hennerich <michael.hennerich@analog.com>
> ---
>  drivers/staging/iio/trigger/iio-trig-sysfs.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/staging/iio/trigger/iio-trig-sysfs.c b/drivers/staging/iio/trigger/iio-trig-sysfs.c
> index 5cd55ac..6d3dee3 100644
> --- a/drivers/staging/iio/trigger/iio-trig-sysfs.c
> +++ b/drivers/staging/iio/trigger/iio-trig-sysfs.c
> @@ -134,7 +134,6 @@ static int iio_sysfs_trigger_probe(int id)
>  	t->id = id;
>  	t->trig = iio_allocate_trigger_named(name);
>  	if (!t->trig) {
> -		kfree(name);
>  		ret = -ENOMEM;
>  		goto free_t;
>  	}


  reply	other threads:[~2011-04-15 12:51 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-15 12:29 [PATCH] IIO-onwards: trigger: iio-trig-sysfs: Avoid double free michael.hennerich
2011-04-15 12:53 ` Jonathan Cameron [this message]
2011-04-15 13:00   ` Hennerich, Michael

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4DA83FB5.7000501@cam.ac.uk \
    --to=jic23@cam.ac.uk \
    --cc=device-drivers-devel@blackfin.uclinux.org \
    --cc=drivers@analog.com \
    --cc=linux-iio@vger.kernel.org \
    --cc=michael.hennerich@analog.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox