From: Jonathan Cameron <jic23@cam.ac.uk>
To: michael.hennerich@analog.com
Cc: linux-iio@vger.kernel.org, drivers@analog.com,
device-drivers-devel@blackfin.uclinux.org
Subject: Re: [PATCH] IIO-onwards: ADC: AD7476: Fix ringbuffer registration
Date: Fri, 15 Apr 2011 14:05:59 +0100 [thread overview]
Message-ID: <4DA842B7.6010905@cam.ac.uk> (raw)
In-Reply-To: <1302859676-24706-1-git-send-email-michael.hennerich@analog.com>
On 04/15/11 10:27, michael.hennerich@analog.com wrote:
> From: Michael Hennerich <michael.hennerich@analog.com>
>
Thanks, merged into rebase of tree. The type cast is no unnecessary
as I've constified inputs to iio_ring_buffer_register_ex
(that was in the branch I accidentally didn't push last night!)
> Signed-off-by: Michael Hennerich <michael.hennerich@analog.com>
> ---
> drivers/staging/iio/adc/ad7476_core.c | 4 +++-
> 1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/staging/iio/adc/ad7476_core.c b/drivers/staging/iio/adc/ad7476_core.c
> index 5867b92..a3cd4cd 100644
> --- a/drivers/staging/iio/adc/ad7476_core.c
> +++ b/drivers/staging/iio/adc/ad7476_core.c
> @@ -209,7 +209,9 @@ static int __devinit ad7476_probe(struct spi_device *spi)
> if (ret)
> goto error_free_device;
>
> - ret = iio_ring_buffer_register(st->indio_dev->ring, 0);
> + ret = iio_ring_buffer_register_ex(st->indio_dev->ring, 0,
> + (struct iio_chan_spec *) st->chip_info->channel,
> + ARRAY_SIZE(st->chip_info->channel));
> if (ret)
> goto error_cleanup_ring;
> return 0;
prev parent reply other threads:[~2011-04-15 13:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-15 9:27 [PATCH] IIO-onwards: ADC: AD7476: Fix ringbuffer registration michael.hennerich
2011-04-15 13:05 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DA842B7.6010905@cam.ac.uk \
--to=jic23@cam.ac.uk \
--cc=device-drivers-devel@blackfin.uclinux.org \
--cc=drivers@analog.com \
--cc=linux-iio@vger.kernel.org \
--cc=michael.hennerich@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox