Re: [PATCH 1/2] IIO-onwards: ADC: AD7887: Convert to new channel registration method.

[Jonathan Cameron <jic23@cam.ac.uk>]

On 04/18/11 14:03, michael.hennerich@analog.com wrote:
> From: Michael Hennerich <michael.hennerich@analog.com>
> 
> Convert to new channel registration method
> Update / change license copyright header
> Add missing call to iio_trigger_notify_done()
Looks good.  I wonder if it would make more sense to have the channel
definitions external to the chip_info structure (have a pointer and size
parameter in there.)  That would allow the driver to handle devices with
different numbers of channels.  Right now it's irrelevant though and can
be easily enough fixed when/if it becomes an issue.

Thanks,

Will slot this one into relevant spot in iio-onwards.
> 
> Signed-off-by: Michael Hennerich <michael.hennerich@analog.com>
Acked-by: Jonathan Cameron <jic23@cam.ac.uk>
> ---
>  drivers/staging/iio/adc/ad7887.h      |   14 ++--
>  drivers/staging/iio/adc/ad7887_core.c |  123 ++++++++++++++-------------------
>  drivers/staging/iio/adc/ad7887_ring.c |   71 +++-----------------
>  3 files changed, 69 insertions(+), 139 deletions(-)