From: Jonathan Cameron <jic23@cam.ac.uk>
To: Guenter Roeck <guenter.roeck@ericsson.com>
Cc: "fabien.marteau@armadeus.com" <fabien.marteau@armadeus.com>,
"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
"lm-sensors@lm-sensors.org" <lm-sensors@lm-sensors.org>
Subject: Re: [PATCH 2/2] staging:iio:adc:as1351 general cleanup and conversion to standard functions.
Date: Thu, 19 May 2011 09:42:49 +0100 [thread overview]
Message-ID: <4DD4D809.5060308@cam.ac.uk> (raw)
In-Reply-To: <20110518163508.GA11675@ericsson.com>
On 05/18/11 17:35, Guenter Roeck wrote:
> On Wed, May 18, 2011 at 12:17:00PM -0400, Jonathan Cameron wrote:
>> V2: Fix the precedence issue Guenter Roeck pointed out.
>>
> Should be below ---, unless you want it in the commit log.
>
>> Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk>
>
> Nitpick below, otherwise
>
> Reviewed-by: Guenter Roeck <guenter.roeck@ericsson.com>
Thanks,
Fixed up as suggested. I'll wait for Fabien's test results
before doing any more with this driver.
next prev parent reply other threads:[~2011-05-19 8:40 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <4DD26311.7070905@armadeus.com>
2011-05-18 15:39 ` [PATCH 0/2] staging:iio:adc:as1531 driver port from hwmon driver Jonathan Cameron
2011-05-18 16:16 ` [PATCH V2 " Jonathan Cameron
2011-05-18 17:01 ` Fabien Marteau
2011-05-18 16:16 ` [PATCH 1/2] staging:iio:adc: as1531 driver initial conversion from hwmon submission Jonathan Cameron
2011-05-18 16:37 ` Guenter Roeck
2011-05-18 16:17 ` [PATCH 2/2] staging:iio:adc:as1351 general cleanup and conversion to standard functions Jonathan Cameron
2011-05-18 16:35 ` Guenter Roeck
2011-05-19 8:42 ` Jonathan Cameron [this message]
2011-05-18 15:39 ` [PATCH 1/2] staging:iio:adc: as1531 driver initial conversion from hwmon submission Jonathan Cameron
2011-05-18 16:02 ` Guenter Roeck
2011-05-18 16:12 ` Jonathan Cameron
2011-05-18 15:39 ` [PATCH 2/2] staging:iio:adc:as1351 general cleanup and conversion to standard functions Jonathan Cameron
2011-05-18 15:57 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DD4D809.5060308@cam.ac.uk \
--to=jic23@cam.ac.uk \
--cc=fabien.marteau@armadeus.com \
--cc=guenter.roeck@ericsson.com \
--cc=linux-iio@vger.kernel.org \
--cc=lm-sensors@lm-sensors.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox