Linux IIO development
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@cam.ac.uk>
To: "linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
	"Hennerich, Michael" <Michael.Hennerich@analog.com>
Subject: Splitting trigger header in two and barriers.
Date: Mon, 11 Jul 2011 16:51:21 +0100	[thread overview]
Message-ID: <4E1B1BF9.4000707@cam.ac.uk> (raw)

Hi All,

The trigger.h file merges elements I'd really rather were separate.
There are some parts that belong to drivers acting as consumers
and others to those acting as producers of triggers.
In a few cases  (e.g. lis3l02dq_ring.c) the consumer and trigger
are in the same file, but in many others the driver only supports
one or the other or has them in separate source files.

The main block to this bit of reorganization ist that some drivers
explicitly put the trigger and detach from it in their 'ring cleanup'
functions (see ad7298_ring.c ad7298_ring_cleanup.)

My original intent was that if a trigger had not been detached from
in userspace, it would not be possible to remmove the driver, so
no cleanup would occur. (basically it counts as being 'in use').

Is there a usecase that demands this explicity disconnect, or
is it simply a case that the reference counting is going wrong
somewhere and hence this was needed in the drivers?

Failing a good description of why this is there in these drivers,
I'd like to clean it out.  Will give us a much easier to follow
interface for the triggers.

Thanks,

Jonathan

             reply	other threads:[~2011-07-11 15:51 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-11 15:51 Jonathan Cameron [this message]
2011-07-11 16:08 ` Splitting trigger header in two and barriers Jonathan Cameron
2011-07-11 16:41   ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E1B1BF9.4000707@cam.ac.uk \
    --to=jic23@cam.ac.uk \
    --cc=Michael.Hennerich@analog.com \
    --cc=linux-iio@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox