Re: [PATCH 2/2] iio: adc: New driver for AD7280A Lithium Ion Battery Monitoring System

[Michael Hennerich <michael.hennerich@analog.com>]

On 07/18/2011 03:36 PM, Michael Hennerich wrote:
> On 07/18/2011 02:56 PM, Jonathan Cameron wrote:
>> On 07/18/11 13:48, Michael Hennerich wrote:
>>> On 07/18/2011 01:43 PM, Jonathan Cameron wrote:
>>>> On 07/15/11 13:59, michael.hennerich@analog.com wrote:
>>>>
>> ...
>>>>> +static irqreturn_t ad7280_event_handler(int irq, void *private)
>>>>> +{
>>>>> +     struct iio_dev *dev_info = private;
>>>>> +
>>>>> +     iio_push_event(dev_info, 0,
>>>>> +                    IIO_UNMOD_EVENT_CODE(IIO_IN,
>>>>> +                                         0,
>>>>> +                                         IIO_EV_TYPE_THRESH,
>>>>> +                                         IIO_EV_DIR_EITHER),
>>>>> +                    iio_get_time_ns());
>>>> You have thresholds for temp and voltage below, but only voltage
>>>> event. I wonder if the right thing here is to issue two events
>>>> (subject to what is enabled).  If everything is turned on, there
>>>> doesn't seem to be anyway to tell what happened.  If the event
>>>> is consistent, I guess you could write a strobe function that would
>>>> enable events up the chain and see when it kicked in. That would
>>>> tell you where it came from.  No idea if one ever wants to know though.
>>> Alternatively I could read all channels in the stack and compare
>>> against the set thresholds. I think that would make the most sense here.
>> Good point. That's much simpler.
>>
Actually - I remember why I didn't do that in the first place.
The bits reserved in IIO_EVENT_CODE for the number are not enough.


-- 
Greetings,
Michael

--
Analog Devices GmbH      Wilhelm-Wagenfeld-Str. 6      80807 Muenchen
Sitz der Gesellschaft: Muenchen; Registergericht: Muenchen HRB 40368;
Geschaeftsfuehrer:Dr.Carsten Suckrow, Thomas Wessel, William A. Martin,
Margaret Seif