Re: 64 bit event code. How to split up?

[Michael Hennerich <michael.hennerich@analog.com>]

On 07/22/2011 11:54 AM, Jonathan Cameron wrote:
> Hi All,
>
> Given Michael has already run out of space in our 32 bit event code I suggest
> we bite the bullet and move over to a 64 bit one now.  I doubt there is much
> userspace code in place so this shouldn't be 'too' painful.
>
> So to start the ball rolling, how about the following split.
> The final will probably still be a macro of doom.  Bitfields get a bit
> confusing cross architectures.  I 'think' the following should even
> be fine of arm oabi (IIRC that has 4 byte alignment for structures).
>
> The following avoids all the conditionals we currently have in the macro.
> It costs us space, but we have more of that. Note we'll need to add
> a NO_MOD modifier and add 1 to all the modifier codes.  It should also
> allow us to use enums for everything.
>
> /**
>   * iio_event - general purpose event to userspace.
>   * @time: timestamp
>   * @chan: index of non differential channel
>   * @chan1: index of first end of differential channel
>   * @chan2: index of second end of differential channel
>   * @chan_type: an iio_chan_type (we currently have 15)
>   * @modifier: currently we interleave several types of these (axial, light).
>   *            having this much space would allow us to relax that and lead to
>   *            simpler code.
>   * @direction: currently only 3, but definitely want level versions as well.
>   * @type: event type (currently thresh, mag, roc). Can see we will have more
>   *        of these.
>   */
>
> struct iio_event {
>          int64_t time;
> 	union {
> 		unsigned chan:32;
> 		struct {
> 			unsigned chan1:16;
> 			unsigned chan2:16;
> 		};
> 	};
> 	unsigned chan_type:8;
> 	unsigned modifier:8;
> 	unsigned direction:8;
> 	unsigned type:8;
> };
>
> So the question is, is this rough and ready distribution of bits good
> enough, or do we need more channel types for example at the cost of some
> directions?
>
Looks good to me.

> I'll hack some patches based on this together shortly so we can see what
> other cleanups it allows.
>
> Jonathan
>

-- 
Greetings,
Michael

--
Analog Devices GmbH      Wilhelm-Wagenfeld-Str. 6      80807 Muenchen
Sitz der Gesellschaft: Muenchen; Registergericht: Muenchen HRB 40368;
Geschaeftsfuehrer:Dr.Carsten Suckrow, Thomas Wessel, William A. Martin,
Margaret Seif