Linux IIO development
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@cam.ac.uk>
To: michael.hennerich@analog.com
Cc: linux-iio@vger.kernel.org,
	device-drivers-devel@blackfin.uclinux.org, drivers@analog.com
Subject: Re: [PATCH] iio: accel: ADIS16209: Fix double registration of in_incli0_index
Date: Fri, 26 Aug 2011 13:00:17 +0100	[thread overview]
Message-ID: <4E578AD1.8080806@cam.ac.uk> (raw)
In-Reply-To: <1314358594-2565-1-git-send-email-michael.hennerich@analog.com>

On 08/26/11 12:36, michael.hennerich@analog.com wrote:
> From: Michael Hennerich <michael.hennerich@analog.com>
> 
> iio (null): tried to double register : in_incli0_index
oops.  That (null) is clearly an issue to.

As for the fix.  Yet another bug due to that pesky IIO_CHAN
macro. hohum.

Thanks and merged.
> 
> Signed-off-by: Michael Hennerich <michael.hennerich@analog.com>
> ---
>  drivers/staging/iio/accel/adis16209_core.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/iio/accel/adis16209_core.c b/drivers/staging/iio/accel/adis16209_core.c
> index 183b5c2..8d5f1d5 100644
> --- a/drivers/staging/iio/accel/adis16209_core.c
> +++ b/drivers/staging/iio/accel/adis16209_core.c
> @@ -431,11 +431,11 @@ static struct iio_chan_spec adis16209_channels[] = {
>  		 (1 << IIO_CHAN_INFO_SCALE_SEPARATE),
>  		 in_aux, ADIS16209_SCAN_AUX_ADC,
>  		 IIO_ST('u', 12, 16, 0), 0),
> -	IIO_CHAN(IIO_INCLI, 0, 1, 0, NULL, 0, IIO_MOD_X,
> +	IIO_CHAN(IIO_INCLI, 1, 0, 0, NULL, 0, IIO_MOD_X,
>  		 (1 << IIO_CHAN_INFO_SCALE_SHARED),
>  		 incli_x, ADIS16209_SCAN_INCLI_X,
>  		 IIO_ST('s', 14, 16, 0), 0),
> -	IIO_CHAN(IIO_INCLI, 0, 1, 0, NULL, 0, IIO_MOD_Y,
> +	IIO_CHAN(IIO_INCLI, 1, 0, 0, NULL, 0, IIO_MOD_Y,
>  		 (1 << IIO_CHAN_INFO_SCALE_SHARED),
>  		 incli_y, ADIS16209_SCAN_INCLI_Y,
>  		 IIO_ST('s', 14, 16, 0), 0),


  reply	other threads:[~2011-08-26 11:52 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-26 11:36 [PATCH] iio: accel: ADIS16209: Fix double registration of in_incli0_index michael.hennerich
2011-08-26 12:00 ` Jonathan Cameron [this message]
2011-08-26 11:56   ` Hennerich, Michael
2011-08-26 12:07     ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E578AD1.8080806@cam.ac.uk \
    --to=jic23@cam.ac.uk \
    --cc=device-drivers-devel@blackfin.uclinux.org \
    --cc=drivers@analog.com \
    --cc=linux-iio@vger.kernel.org \
    --cc=michael.hennerich@analog.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox