From: Jonathan Cameron <jic23@cam.ac.uk>
To: michael.hennerich@analog.com
Cc: linux-iio@vger.kernel.org,
device-drivers-devel@blackfin.uclinux.org, drivers@analog.com
Subject: Re: [PATCH] iio: ad7152: fix channel assignment for AD7153
Date: Thu, 01 Sep 2011 14:10:49 +0100 [thread overview]
Message-ID: <4E5F8459.7030400@cam.ac.uk> (raw)
In-Reply-To: <1314876904-20984-1-git-send-email-michael.hennerich@analog.com>
On 09/01/11 12:35, michael.hennerich@analog.com wrote:
> From: Michael Hennerich <michael.hennerich@analog.com>
>
> In case the AD7153 is selected we need to make sure we provide channel info
> for the first capacitance input in both single ended and differential
> configuration.
Good point. I didn't think my original fix through.
>
> Signed-off-by: Michael Hennerich <michael.hennerich@analog.com>
merged
looks like master.kernel.org is still undergoing reinstall so it'll be local
to me for a while (or to Greg when I've sent it on).
> ---
> drivers/staging/iio/adc/ad7152.c | 8 ++++----
> 1 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/iio/adc/ad7152.c b/drivers/staging/iio/adc/ad7152.c
> index 42efc37..dac3392 100644
> --- a/drivers/staging/iio/adc/ad7152.c
> +++ b/drivers/staging/iio/adc/ad7152.c
> @@ -440,17 +440,17 @@ static const struct iio_chan_spec ad7152_channels[] = {
> (1 << IIO_CHAN_INFO_SCALE_SEPARATE),
> }, {
> .type = IIO_CAPACITANCE,
> + .differential = 1,
> .indexed = 1,
> - .channel = 1,
> + .channel = 0,
> + .channel2 = 2,
> .info_mask = (1 << IIO_CHAN_INFO_CALIBSCALE_SEPARATE) |
> (1 << IIO_CHAN_INFO_CALIBBIAS_SEPARATE) |
> (1 << IIO_CHAN_INFO_SCALE_SEPARATE),
> }, {
> .type = IIO_CAPACITANCE,
> - .differential = 1,
> .indexed = 1,
> - .channel = 0,
> - .channel2 = 2,
> + .channel = 1,
> .info_mask = (1 << IIO_CHAN_INFO_CALIBSCALE_SEPARATE) |
> (1 << IIO_CHAN_INFO_CALIBBIAS_SEPARATE) |
> (1 << IIO_CHAN_INFO_SCALE_SEPARATE),
parent reply other threads:[~2011-09-01 13:02 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <1314876904-20984-1-git-send-email-michael.hennerich@analog.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E5F8459.7030400@cam.ac.uk \
--to=jic23@cam.ac.uk \
--cc=device-drivers-devel@blackfin.uclinux.org \
--cc=drivers@analog.com \
--cc=linux-iio@vger.kernel.org \
--cc=michael.hennerich@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).