From: Jonathan Cameron <jic23@cam.ac.uk>
To: Jonathan Cameron <jic23@cam.ac.uk>
Cc: michael.hennerich@analog.com, linux-iio@vger.kernel.org,
device-drivers-devel@blackfin.uclinux.org, drivers@analog.com
Subject: Re: [PATCH] iio: adc: Replace, rewrite ad7745 from scratch.
Date: Mon, 19 Sep 2011 13:54:57 +0100 [thread overview]
Message-ID: <4E773BA1.4060007@cam.ac.uk> (raw)
In-Reply-To: <4E77334A.1000207@cam.ac.uk>
On 09/19/11 13:19, Jonathan Cameron wrote:
>
> One quick nitpick on submission format:
> Please put version in the email subject
> [PATCH V3] iio:...
>
> That way it's easy to spot which one to bother reading ;)
>
> On 09/16/11 15:47, michael.hennerich@analog.com wrote:
>> From: Michael Hennerich <michael.hennerich@analog.com>
>>
>> The existing ad7745 driver didn't conform with the IIO spec for such devices.
>> It was way simpler to rewrite the existing driver, than actually fixing it.
>>
>> Changes since V1:
>>
>> Fix file header description.
>> Fix erroneous defines.
>> Pin channels to expected places in the iio_chan_spec array, to avoid magic numbers.
>> Use msleep instead of busy waiting mdelay.
>> Fix indention style.
>> Drop _bias and use _offset attribute.
>>
>> Changes since V2:
>> Increase accuracy of cap scale.
>> Fix channel spec for VIN.
> Some formatting nitpicks. I'll fix them up.
Coccicheck gave me a missaligned code error as well whilst I was doing
final checks...
>> + case IIO_VOLTAGE:
>> + if (chan->channel == 1) /* supply_raw*/
>> + *val = *val * 6;
>> + break;
Indent wrong above. Fixed up.
next prev parent reply other threads:[~2011-09-19 12:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-16 14:47 [PATCH] iio: adc: Replace, rewrite ad7745 from scratch michael.hennerich
2011-09-19 12:19 ` Jonathan Cameron
2011-09-19 12:54 ` Jonathan Cameron [this message]
2011-09-19 19:44 ` Hennerich, Michael
2011-09-20 9:15 ` Jonathan Cameron
-- strict thread matches above, loose matches on Subject: below --
2011-09-16 13:12 michael.hennerich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E773BA1.4060007@cam.ac.uk \
--to=jic23@cam.ac.uk \
--cc=device-drivers-devel@blackfin.uclinux.org \
--cc=drivers@analog.com \
--cc=linux-iio@vger.kernel.org \
--cc=michael.hennerich@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).