* [patch] Staging: iio/adc/ad7150: release lock on error
@ 2011-10-06 6:17 Dan Carpenter
2011-10-06 11:10 ` Jonathan Cameron
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2011-10-06 6:17 UTC (permalink / raw)
To: Jonathan Cameron
Cc: Greg Kroah-Hartman, Michael Hennerich, Paul Gortmaker,
Mike Frysinger, linux-iio, devel, kernel-janitors
The error_ret label should have been before the mutex_unlock(). It's
a typo.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/staging/iio/adc/ad7150.c b/drivers/staging/iio/adc/ad7150.c
index 8943420..d1767d8 100644
--- a/drivers/staging/iio/adc/ad7150.c
+++ b/drivers/staging/iio/adc/ad7150.c
@@ -332,8 +332,8 @@ static int ad7150_write_event_value(struct iio_dev *indio_dev,
/* write back if active */
ret = ad7150_write_event_params(indio_dev, event_code);
- mutex_unlock(&chip->state_lock);
error_ret:
+ mutex_unlock(&chip->state_lock);
return ret;
}
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [patch] Staging: iio/adc/ad7150: release lock on error
2011-10-06 6:17 [patch] Staging: iio/adc/ad7150: release lock on error Dan Carpenter
@ 2011-10-06 11:10 ` Jonathan Cameron
0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Cameron @ 2011-10-06 11:10 UTC (permalink / raw)
To: Dan Carpenter
Cc: Greg Kroah-Hartman, Michael Hennerich, Paul Gortmaker,
Mike Frysinger, linux-iio, devel, kernel-janitors
On 10/06/11 07:17, Dan Carpenter wrote:
> The error_ret label should have been before the mutex_unlock(). It's
> a typo.
Good catch thanks!
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Jonathan Cameron <jic23@cam.ac.uk>
>
> diff --git a/drivers/staging/iio/adc/ad7150.c b/drivers/staging/iio/adc/ad7150.c
> index 8943420..d1767d8 100644
> --- a/drivers/staging/iio/adc/ad7150.c
> +++ b/drivers/staging/iio/adc/ad7150.c
> @@ -332,8 +332,8 @@ static int ad7150_write_event_value(struct iio_dev *indio_dev,
> /* write back if active */
> ret = ad7150_write_event_params(indio_dev, event_code);
>
> - mutex_unlock(&chip->state_lock);
> error_ret:
> + mutex_unlock(&chip->state_lock);
> return ret;
> }
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-10-06 11:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-10-06 6:17 [patch] Staging: iio/adc/ad7150: release lock on error Dan Carpenter
2011-10-06 11:10 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).