* [patch 1/2] Staging: iio/light/tsl2563: unlock on an error path
@ 2011-10-06 6:15 Dan Carpenter
2011-10-06 11:24 ` Jonathan Cameron
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2011-10-06 6:15 UTC (permalink / raw)
To: Jonathan Cameron
Cc: Greg Kroah-Hartman, Bryan Freed, Michael Hennerich, Arnd Bergmann,
linux-iio, devel, kernel-janitors
We need to unlock here before returning.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/staging/iio/light/tsl2563.c b/drivers/staging/iio/light/tsl2563.c
index 3707772..8977f58 100644
--- a/drivers/staging/iio/light/tsl2563.c
+++ b/drivers/staging/iio/light/tsl2563.c
@@ -518,7 +518,8 @@ static int tsl2563_read_raw(struct iio_dev *indio_dev,
ret = IIO_VAL_INT;
break;
default:
- return -EINVAL;
+ ret = -EINVAL;
+ goto error_ret;
}
error_ret:
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [patch 1/2] Staging: iio/light/tsl2563: unlock on an error path
2011-10-06 6:15 [patch 1/2] Staging: iio/light/tsl2563: unlock on an error path Dan Carpenter
@ 2011-10-06 11:24 ` Jonathan Cameron
0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Cameron @ 2011-10-06 11:24 UTC (permalink / raw)
To: Dan Carpenter
Cc: Greg Kroah-Hartman, Bryan Freed, Michael Hennerich, Arnd Bergmann,
linux-iio, devel, kernel-janitors
On 10/06/11 07:15, Dan Carpenter wrote:
> We need to unlock here before returning.
Thanks
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Jonathan Cameron <jic23@cam.ac.uk>
>
> diff --git a/drivers/staging/iio/light/tsl2563.c b/drivers/staging/iio/light/tsl2563.c
> index 3707772..8977f58 100644
> --- a/drivers/staging/iio/light/tsl2563.c
> +++ b/drivers/staging/iio/light/tsl2563.c
> @@ -518,7 +518,8 @@ static int tsl2563_read_raw(struct iio_dev *indio_dev,
> ret = IIO_VAL_INT;
> break;
> default:
> - return -EINVAL;
> + ret = -EINVAL;
> + goto error_ret;
> }
>
> error_ret:
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-10-06 11:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-10-06 6:15 [patch 1/2] Staging: iio/light/tsl2563: unlock on an error path Dan Carpenter
2011-10-06 11:24 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).