From: Jonathan Cameron <jic23@kernel.org>
To: guenter.roeck@ericsson.com
Cc: "linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"khali@linux-fr.org" <khali@linux-fr.org>,
"dmitry.torokhov@gmail.com" <dmitry.torokhov@gmail.com>,
"broonie@opensource.wolfsonmicro.com"
<broonie@opensource.wolfsonmicro.com>,
"gregkh@suse.de" <gregkh@suse.de>,
"alan@lxorguk.ukuu.org.uk" <alan@lxorguk.ukuu.org.uk>,
"arnd@arndb.de" <arnd@arndb.de>,
"linus.walleij@linaro.org" <linus.walleij@linaro.org>,
"lars@metafoo.de" <lars@metafoo.de>,
"maxime.ripard@free-electrons.com"
<maxime.ripard@free-electrons.com>,
"lm-sensors@lm-sensors.org" <lm-sensors@lm-sensors.org>,
"thomas.petazzoni@free-electrons.com"
<thomas.petazzoni@free-electrons.com>,
"zdevai@gmail.com" <zdevai@gmail.com>,
Jonathan Cameron <jic23@cam.ac.uk>
Subject: Re: [PATCH 4/5] IIO:hwmon interface client driver.
Date: Mon, 07 Nov 2011 17:39:18 +0000 [thread overview]
Message-ID: <4EB817C6.5070503@kernel.org> (raw)
In-Reply-To: <1320683392.2309.109.camel@groeck-laptop>
>> +static int __devexit iio_hwmon_remove(struct platform_device *pdev)
>> +{
>> + struct iio_hwmon_state *st = platform_get_drvdata(pdev);
>> +
>> + hwmon_device_unregister(st->hwmon_dev);
>> + sysfs_remove_group(&pdev->dev.kobj, &st->attr_group);
>> + iio_hwmon_free_attrs(st);
>> + kfree(st->attrs);
>> + iio_channel_release_all(st->channels);
>> +
>
> Either I missed it before, or I am missing something now ... should
> there be kfree(st) here ?
>
> Thanks,
> Guenter
Gah! you are quite right. Good spot. I'll fix that one up and repost
this individual patch.
next prev parent reply other threads:[~2011-11-07 17:39 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-07 15:44 [PATCH 0/5 V4] IIO in kernel interfaces (pull) Jonathan Cameron
2011-11-07 15:44 ` [PATCH 1/5] IIO: core: add datasheet_name to chan_spec Jonathan Cameron
2011-11-07 15:44 ` [PATCH 2/5] IIO:ADC:max1363 add datasheet_name entries Jonathan Cameron
2011-11-07 15:44 ` [PATCH 3/5] IIO:CORE add in kernel interface mapping and getting IIO channels Jonathan Cameron
2011-11-10 13:25 ` Mark Brown
2011-11-10 17:04 ` Jonathan Cameron
2011-11-11 15:42 ` Linus Walleij
2011-11-07 15:44 ` [PATCH 4/5] IIO:hwmon interface client driver Jonathan Cameron
2011-11-07 16:29 ` Guenter Roeck
2011-11-07 17:39 ` Jonathan Cameron [this message]
2011-11-07 17:43 ` [PATCH] " Jonathan Cameron
2011-11-07 17:52 ` Guenter Roeck
2011-11-07 18:09 ` Jonathan Cameron
2011-11-07 15:44 ` [PATCH 5/5] stargate2: example of map configuration for iio to hwmon example Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EB817C6.5070503@kernel.org \
--to=jic23@kernel.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=arnd@arndb.de \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=dmitry.torokhov@gmail.com \
--cc=gregkh@suse.de \
--cc=guenter.roeck@ericsson.com \
--cc=jic23@cam.ac.uk \
--cc=khali@linux-fr.org \
--cc=lars@metafoo.de \
--cc=linus.walleij@linaro.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lm-sensors@lm-sensors.org \
--cc=maxime.ripard@free-electrons.com \
--cc=thomas.petazzoni@free-electrons.com \
--cc=zdevai@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).