From: Jonathan Cameron <jic23@cam.ac.uk>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Jonathan Cameron <jic23@kernel.org>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
guenter.roeck@ericsson.com, khali@linux-fr.org,
dmitry.torokhov@gmail.com, gregkh@suse.de,
alan@lxorguk.ukuu.org.uk, arnd@arndb.de,
linus.walleij@linaro.org, lars@metafoo.de,
maxime.ripard@free-electrons.com, lm-sensors@lm-sensors.org,
thomas.petazzoni@free-electrons.com, zdevai@gmail.com
Subject: Re: [PATCH 3/5] IIO:CORE add in kernel interface mapping and getting IIO channels.
Date: Thu, 10 Nov 2011 17:04:24 +0000 [thread overview]
Message-ID: <4EBC0418.2040005@cam.ac.uk> (raw)
In-Reply-To: <20111110132506.GF3832@opensource.wolfsonmicro.com>
On 11/10/2011 01:25 PM, Mark Brown wrote:
> On Mon, Nov 07, 2011 at 03:44:39PM +0000, Jonathan Cameron wrote:
>> From: Jonathan Cameron <jic23@cam.ac.uk>
>>
>> Two elements here:
>> * Map as defined in include/linux/iio/inkern.h
>> * Matching code to actually get the iio_dev and channel
>> that we want from the global list of IIO devices.
>
> I've not read it thoroughly but this certainly this looks sensible from
> an external interface point of view, I'd expect that issues can be
> worked through incrementally.
>
> Reviewed-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
Thanks.
>
>> +extern struct list_head iio_map_list;
>
> It's surprising that this is part of the external interface of IIO
> rather than something hidden within the implementation.
You are quite correct. I was being lazy and had that one element that
didn't fit in any headers. I'lll add a trivial inkern-core.h to handle
that one bit.
next prev parent reply other threads:[~2011-11-10 17:04 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-07 15:44 [PATCH 0/5 V4] IIO in kernel interfaces (pull) Jonathan Cameron
2011-11-07 15:44 ` [PATCH 1/5] IIO: core: add datasheet_name to chan_spec Jonathan Cameron
2011-11-07 15:44 ` [PATCH 2/5] IIO:ADC:max1363 add datasheet_name entries Jonathan Cameron
2011-11-07 15:44 ` [PATCH 3/5] IIO:CORE add in kernel interface mapping and getting IIO channels Jonathan Cameron
2011-11-10 13:25 ` Mark Brown
2011-11-10 17:04 ` Jonathan Cameron [this message]
2011-11-11 15:42 ` Linus Walleij
2011-11-07 15:44 ` [PATCH 4/5] IIO:hwmon interface client driver Jonathan Cameron
2011-11-07 16:29 ` Guenter Roeck
2011-11-07 17:39 ` Jonathan Cameron
2011-11-07 17:43 ` [PATCH] " Jonathan Cameron
2011-11-07 17:52 ` Guenter Roeck
2011-11-07 18:09 ` Jonathan Cameron
2011-11-07 15:44 ` [PATCH 5/5] stargate2: example of map configuration for iio to hwmon example Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EBC0418.2040005@cam.ac.uk \
--to=jic23@cam.ac.uk \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=arnd@arndb.de \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=dmitry.torokhov@gmail.com \
--cc=gregkh@suse.de \
--cc=guenter.roeck@ericsson.com \
--cc=jic23@kernel.org \
--cc=khali@linux-fr.org \
--cc=lars@metafoo.de \
--cc=linus.walleij@linaro.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lm-sensors@lm-sensors.org \
--cc=maxime.ripard@free-electrons.com \
--cc=thomas.petazzoni@free-electrons.com \
--cc=zdevai@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).